mirror of
https://github.com/bytedance/deer-flow.git
synced 2026-09-16 17:46:20 +00:00
73e3699347
* feat(frontend): render markdown artifacts in the new window The artifacts panel's "open in new window" action handed the browser the raw Gateway response. For markdown that is a `text/markdown` body the browser can only show as source, so the new window was a text dump rather than a reader. Route markdown artifacts to a new `/artifacts/view` page that renders them with the same components the panel uses (SafeStreamdown + the artifact rehype chain + citation links/panel), including the truncated-preview banner and its "load full file" action. Everything else keeps the raw Gateway URL — notably HTML/SVG, which the Gateway deliberately serves as a download so active content never executes in the application origin. - `core/artifacts/viewer.ts` centralizes which stored artifacts are markdown (`.skill` archives included, since they hold a SKILL.md), so the panel and the viewer route cannot drift. - `ArtifactFilePreview` and its siblings move out of `artifact-file-detail.tsx` into `artifact-file-preview.tsx`; otherwise the standalone route would pull the CodeMirror editor into its bundle. - The window title comes from the route's `generateMetadata`, not `document.title`, which the App Router overwrites after hydration. - The viewer reads content through `useStandaloneArtifactContent`, which shares `useArtifactContent`'s query key but not its `useThread` dependency, since a detached window has no thread context. Claude-Session: https://claude.ai/code/session_013AiCrC5SBc3HdFYNxsp1EC * fix(frontend): keep the artifact target across re-authentication Review found the standalone viewer unrecoverable from an expired session. The window's target lives entirely in `?path=...&thread_id=...`, and both auth paths dropped it: - The layout guard redirected to `/login` with no `next` at all. A layout cannot read `searchParams`, so the guard moves into the page, which can — and rebuilds the full viewer address for `next`. The layout loses its AuthProvider along the way: nothing under this route reads `useAuth`, and the guard now makes a single `getServerSideUser` call per request. - The shared fetch wrapper built `next` from `window.location.pathname`, which silently truncated the query string. It now carries `search` too, so any route holding state in the query survives a 401, not just this one. `validateAuthNextPath` already accepts a query string. `buildArtifactViewerURL` is split out of `resolveArtifactOpenURL`: the guard needs the route itself, never the Gateway fallback that the latter takes for non-markdown targets. Tests: the login round trip (unit — the rebuilt URL survives `validateAuthNextPath` and parses back to the same target), the fetch wrapper preserving the query on 401 (unit), and the expired-session window reaching `/login` with the artifact intact (E2E). The E2E asserts on the popup's navigation *requests*, since `(auth)/layout` answers `/login` with a server redirect under DEER_FLOW_AUTH_DISABLED and no navigation commits. `tests/unit/core/models/api.test.ts` stubbed `window.location` without `search`; a real Location always has it. Claude-Session: https://claude.ai/code/session_013AiCrC5SBc3HdFYNxsp1EC * fix(frontend): keep public showcase artifacts out of the auth gate Review found that the viewer's access check regressed `/showcase`. Those pages render with `isMock`, their artifacts are served by the unauthenticated demo route, and the raw artifact URL this window replaced stayed public — so gating the window unconditionally bounced every logged-out showcase visitor to /login for a document that is already public. `requiresAuthenticatedViewer` exempts a mock target only when `resolveStaticDemoArtifact` would actually serve it. The allowlist is the authority rather than the flag: `mock=true` is caller-supplied, so a target the demo route answers with 404 — a non-allowlisted path, or a thread that is not a demo thread — still needs a session. Covered in `tests/e2e-auth/`, since the default E2E config disables auth and cannot see this: a public showcase artifact renders without a session, while a non-allowlisted path and a missing mock flag both land on /login. Verified the positive case goes red without the exemption. Claude-Session: https://claude.ai/code/session_013AiCrC5SBc3HdFYNxsp1EC
50 lines
1.8 KiB
TypeScript
50 lines
1.8 KiB
TypeScript
import { readFileSync } from "node:fs";
|
|
import path from "node:path";
|
|
|
|
import { describe, expect, it } from "@rstest/core";
|
|
|
|
const FRONTEND_ROOT = path.resolve(__dirname, "../../..");
|
|
|
|
function source(relativePath: string) {
|
|
return readFileSync(path.join(FRONTEND_ROOT, relativePath), "utf8");
|
|
}
|
|
|
|
describe("layout performance boundaries", () => {
|
|
it("keeps request locale and rich-content styles out of the root layout", () => {
|
|
const rootLayout = source("src/app/layout.tsx");
|
|
|
|
expect(rootLayout).not.toContain("detectLocaleServer");
|
|
expect(rootLayout).not.toContain("I18nProvider");
|
|
expect(rootLayout).not.toContain("katex/dist/katex.min.css");
|
|
expect(rootLayout).not.toContain("streamdown/styles.css");
|
|
expect(rootLayout).toContain("DEFAULT_LOCALE");
|
|
});
|
|
|
|
it("assigns rich-content styles to routes that render them", () => {
|
|
expect(source("src/app/workspace/layout.tsx")).toContain(
|
|
'import "streamdown/styles.css"',
|
|
);
|
|
expect(source("src/app/[lang]/docs/layout.tsx")).toContain(
|
|
'import "katex/dist/katex.min.css"',
|
|
);
|
|
expect(source("src/app/blog/layout.tsx")).toContain(
|
|
'import "katex/dist/katex.min.css"',
|
|
);
|
|
const artifactViewerLayout = source("src/app/artifacts/view/layout.tsx");
|
|
expect(artifactViewerLayout).toContain('import "streamdown/styles.css"');
|
|
expect(artifactViewerLayout).toContain('import "katex/dist/katex.min.css"');
|
|
});
|
|
|
|
it("passes only serializable locale state through server layouts", () => {
|
|
for (const layout of [
|
|
source("src/app/(auth)/layout.tsx"),
|
|
source("src/app/workspace/layout.tsx"),
|
|
source("src/app/artifacts/view/layout.tsx"),
|
|
]) {
|
|
expect(layout).toContain("detectLocaleServer");
|
|
expect(layout).not.toContain("initialTranslations");
|
|
expect(layout).not.toContain("getI18n");
|
|
}
|
|
});
|
|
});
|