Nan Gao 1f792d0f4b
feat(extensions): add middleware plugin foundation (#4636)
* feat(extensions): add middleware plugin foundation

* fix(extensions): stop config resolution from masking extension loading

`create_app()` resolved the configured plugin list inside the fail-open
guard around `load_extensions()`. CI has no `config.yaml` (gitignored and
never generated by the workflow), so `get_app_config()` raised
`FileNotFoundError` there and was swallowed as an extension failure --
`load_extensions()` never ran at all, and the four `create_app()` tests in
`test_extension_app_loading.py` passed locally but failed on every runner.

Resolve the plugin list before the guard. Only an absent `config.yaml` is
tolerated, mirroring `_resolve_trace_enabled_for_app_construction()`:
`create_app()` runs at import time, and lifespan still performs strict
config loading before serving. A `config.yaml` that exists but fails to
parse or validate now propagates instead of being reported as an extension
failure -- reporting it as the latter silently dropped a `required: true`
extension rather than failing the boot.

Make the tests config-independent with an autouse `stub_app_config`
fixture, following the existing pattern in `test_gateway_lifespan_shutdown.py`,
and cover both new branches of the config-resolution boundary.

* fix(extensions): bind the run's extension snapshot through subagent delegation

The lead-agent path resolves one immutable loaded-extension snapshot per run
and binds it through task-store allocation and graph construction, but the
subagent path re-read the process-wide singleton at execution time. In
production both are the same object, yet a `set_loaded_extensions()` between
the lead run's start and a subagent's execution (test teardown, a future
hot-reload path) would let one run mix two extension generations — exactly what
the documented invariant exists to prevent.

The graph-build binding is a ContextVar scoped to synchronous construction, so
it has already exited by the time a tool delegates; the snapshot has to travel
through runtime context instead. The run worker publishes it under the
host-internal `EXTENSION_SNAPSHOT_CONTEXT_KEY` (written after the caller merge,
popped when the run has none, so a caller-supplied value is never
authoritative), `task_tool` reads it back through the type-checking
`resolve_run_extensions()`, and `SubagentExecutor` binds it at construction.

Callers outside the Gateway run path — embedded `DeerFlowClient`, standalone
LangGraph Server — install no snapshot and keep the existing
`get_loaded_extensions()` fallback.

* refactor(extensions): defer the ordering table by call, not by a lying tuple

`CORE_ORDERING_CONSTRAINTS` was a `tuple` subclass that overrode only
`__iter__` and resolved into a class-level `_resolved` side channel. A tuple
cannot populate its own storage after construction, so the instance stayed the
empty tuple it was built as: `len()` was 0, `bool()` was False, `in` was always
False, indexing raised, slicing and `reversed()` came back empty, and it
compared unequal to the plain tuples tests substitute for it — all while
iteration yielded the real constraints. Only `assert_ordering` consumed it, and
only by iterating, so the split went unnoticed.

The sibling `_AnchorTable(dict)` uses the same idea soundly because dict is
mutable: `self.update()` fills the real storage, making every inherited
operation correct. That trick does not survive the port to an immutable type.

Replace it with `core_ordering_constraints()`, matching how `stack.py` defers
the same kind of table via `_anchors()`. The deferral is kept — it is about
dependency direction, not just cycles: `extensions/` is the layer the
middleware layer calls into, so a module-scope `agents.middlewares` import here
points the dependency backwards and closes a cycle as soon as any middleware
imports something under `extensions/` at module level. Resolution stays at
`assert_ordering` time, which already runs inside the middleware builder.

Tests pin both halves: the returned value is a plain tuple whose len/bool/
membership/indexing/reversal/equality agree with iteration, and a subprocess
probe asserts importing `extensions.ordering` does not load the middleware
layer while calling the function does.
2026-08-04 22:33:26 +08:00

192 lines
7.1 KiB
Python

"""The anchor table and the single composition entry point.
This is where DeerFlow's stack shape is encoded. Two structural facts drive it:
* The stack is built at two nested points — `build_lead_runtime_middlewares()`
produces the base, then `build_middlewares()` appends ~18 lead-specific
middlewares that are all *inner* of it. MODEL_PHYSICAL lands in the second
group, so extension injection must happen after the final list is assembled,
never inside the base builder.
* First item in the list is the outermost wrapper (LangChain composition rule).
"""
from __future__ import annotations
from collections.abc import Sequence
from deerflow_extension_api import AgentBuildContext, AgentScope, Placement
from deerflow.extensions.anchors import (
PlacementAnchor,
inner_of_last,
inner_of_last_after,
innermost,
outer_of,
outer_of_last,
outermost,
)
from deerflow.extensions.injection import inject_middlewares
from deerflow.extensions.ordering import assert_ordering
from deerflow.extensions.registry import LoadedExtensions
def _anchors() -> dict[Placement, PlacementAnchor]:
from deerflow.agents.middlewares.clarification_middleware import ClarificationMiddleware
from deerflow.agents.middlewares.llm_error_handling_middleware import LLMErrorHandlingMiddleware
from deerflow.agents.middlewares.safety_finish_reason_middleware import SafetyFinishReasonMiddleware
from deerflow.agents.middlewares.terminal_response_middleware import TerminalResponseMiddleware
return {
# Outer of the retry loop, so one logical decision stays one event even
# when LLMErrorHandlingMiddleware retries underneath.
Placement.MODEL_LOGICAL: outer_of(LLMErrorHandlingMiddleware),
# Inner of every lead-agent request transform. Deliberately NOT
# innermost(): ClarificationMiddleware sits inner of this point today,
# and moving the anchor past it would change what "the final request"
# means.
Placement.MODEL_PHYSICAL: PlacementAnchor.of(
inner_of_last_after(
SafetyFinishReasonMiddleware,
after=(TerminalResponseMiddleware,),
),
inner_of_last(TerminalResponseMiddleware),
outer_of_last(ClarificationMiddleware),
innermost(),
),
Placement.TOOL_VISIBLE: outermost(),
# As close to the tool callable as the chain allows. Deliberately NOT
# inner_of(ToolErrorHandlingMiddleware): SkillToolPolicyMiddleware and
# ClarificationMiddleware are appended later and also wrap tool calls,
# so anchoring there left two wrappers inner of "raw" and the placement
# silently stopped meaning what it says.
#
# ClarificationMiddleware remains the one carve-out, the same shape as
# MODEL_PHYSICAL's above: it must stay last (it short-circuits the tool
# loop with Command(goto=END)), and it only ever intercepts
# ask_clarification — it does not transform the result of any tool that
# actually executes, so TOOL_RAW still sees raw results.
Placement.TOOL_RAW: PlacementAnchor.of(
outer_of_last(ClarificationMiddleware),
innermost(),
),
Placement.STANDARD: PlacementAnchor.of(
outer_of(LLMErrorHandlingMiddleware),
innermost(),
),
}
class _AnchorTable(dict):
"""Resolve the table lazily so importing this module stays cheap and
free of middleware import cycles."""
_loaded = False
def _ensure(self) -> None:
if not _AnchorTable._loaded:
self.update(_anchors())
_AnchorTable._loaded = True
def __getitem__(self, key):
self._ensure()
return dict.__getitem__(self, key)
def get(self, key, default=None):
self._ensure()
return dict.get(self, key, default)
def __iter__(self):
self._ensure()
return dict.__iter__(self)
def __len__(self):
self._ensure()
return dict.__len__(self)
def snapshot(self) -> dict[Placement, PlacementAnchor]:
"""Return a populated plain-dict copy.
CPython's ``dict(subclass)`` fast path can copy the underlying storage
without calling this class's lazy ``__iter__`` or ``__len__`` hooks.
Callers that need a copy must therefore force resolution explicitly.
"""
self._ensure()
return dict(self)
PLACEMENT_ANCHORS = _AnchorTable()
def _placement_anchors_for_scope(scope: AgentScope) -> dict[Placement, PlacementAnchor]:
if scope != AgentScope.SUBAGENT:
return PLACEMENT_ANCHORS
from deerflow.agents.middlewares.system_message_coalescing_middleware import SystemMessageCoalescingMiddleware
anchors = PLACEMENT_ANCHORS.snapshot()
anchors[Placement.MODEL_PHYSICAL] = PlacementAnchor.of(
inner_of_last(SystemMessageCoalescingMiddleware),
PLACEMENT_ANCHORS[Placement.MODEL_PHYSICAL],
)
return anchors
def compose_with_extensions(
middlewares: Sequence[object],
scope: AgentScope,
ctx: AgentBuildContext | None,
extensions: LoadedExtensions | None = None,
) -> list[object]:
"""Merge extension contributions into a fully-assembled stack and validate.
Call this once, at the end of the outermost builder. Calling it inside the
base builder would place MODEL_PHYSICAL contributions above the ~18
lead-specific middlewares appended afterwards.
"""
from deerflow.extensions import get_agent_build_extensions, record_runtime_diagnostic
resolved = extensions if extensions is not None else get_agent_build_extensions()
if not resolved.has_middleware_contributors:
assert_ordering(middlewares, {})
return middlewares if isinstance(middlewares, list) else list(middlewares)
if ctx is None:
raise ValueError("AgentBuildContext is required when middleware extensions are loaded")
result = list(middlewares)
result, provenance, diagnostics = inject_middlewares(
result,
_placement_anchors_for_scope(scope),
scope,
ctx,
resolved,
isolation_diagnostic_sink=record_runtime_diagnostic,
)
_record_diagnostics(diagnostics)
assert_ordering(result, provenance)
return result
def _record_diagnostics(diagnostics) -> None:
"""Diagnostics raised while building a stack are logged by their producers;
this hook exists so the Gateway can also surface them on app.state."""
from deerflow.extensions import record_runtime_diagnostics
record_runtime_diagnostics(diagnostics)
def middleware_implements(middleware: object, hook_name: str) -> bool:
"""Whether ``middleware`` actually overrides ``hook_name``.
Placement guarantees are per hook chain, not per list index: a middleware's
position only means something on the chains it participates in. This is how
the guarantee tests tell participation from mere presence.
"""
from langchain.agents.middleware import AgentMiddleware
own = getattr(type(middleware), hook_name, None)
base = getattr(AgentMiddleware, hook_name, None)
return own is not None and own is not base