ajayr 6456c35675

fix(browserless): accept the timeout config key and harden coercion (#4519) ...

`browserless` reads `cfg["timeout_s"]`, while its sibling web providers
`crawl4ai` and `jina_ai` read `cfg["timeout"]`. Tool configs allow extra
fields, so the unrecognised spelling is dropped without a diagnostic: someone
adapting one provider's config snippet for another silently gets the 30s
default instead of the timeout they set. (Observed in the other direction, on a
deployment whose crawl4ai entry carried `timeout_s`.)

Accept both keys, preferring the documented `timeout_s` when both are present.

While adding coverage, two pre-existing bugs in the same three lines surfaced,
both already guarded in crawl4ai/jina_ai but not here:

- `timeout_s: "30s"` (or any non-numeric string) raised ValueError out of
  `float(raw)` during tool construction rather than falling back.
- `timeout_s: off` -- YAML parses that as `False`, and `float(False)` is
  `0.0`, so every request timed out immediately against a healthy server.

`_coerce_timeout` now mirrors the sibling providers: booleans and unparsable
strings fall back to the default, with a warning for the string case.

Tests: five cases in tests/test_browserless_client.py covering both keys, the
precedence order, and both coercion bugs. Verified red before the fix (3 of 5
fail) and green after.

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

2026-07-28 07:56:04 +08:00

..

__init__.py

feat(community): add Browserless web_capture screenshot tool (#3881)

2026-07-01 23:41:58 +08:00

browserless_client.py

fix(browserless): surface target-page error status in web_fetch_tool (#4239)

2026-07-19 20:08:52 +08:00

tools.py

fix(browserless): accept the timeout config key and harden coercion (#4519)

2026-07-28 07:56:04 +08:00