mirror of
https://github.com/bytedance/deer-flow.git
synced 2026-07-28 00:48:07 +00:00
6a4e5a3bb2
* feat(frontend): add side conversations for quoted follow-ups * style(frontend): apply prettier formatting to sidecar-chat files * fix(frontend): surface sidecar cascade cleanup failures via console.warn Previously deleteSidecarThreadsForParent silently swallowed both lookup errors and per-thread deletion failures, so parent thread deletions could succeed while orphaning sidecar threads with no signal to the caller. Log a warning that includes the parent id and the failed thread ids/reasons so the leak is discoverable in telemetry, matching the existing console.warn/error pattern in this file. * fix(frontend): address all sidecar review feedback Resolve every reviewer comment on PR #3934: - input-box/hooks/sidecar-panel: clear quoted references only via an `onSent` callback that fires after the in-flight guard, so a dropped send no longer silently discards quotes (willem-bd #3550). - message-list: flip the selection toolbar below the selection when it would clip above the viewport (willem-bd #3551). - reference-metadata/thread/input-box: keep referenced ids, roles, and count arrays 1:1 parallel instead of deduping ids (willem-bd #3552). - message-list: widen selection containment to the shared assistant-turn container and hint when a selection crosses messages (willem-bd #3553). - sidecar/api: coalesce concurrent sidecar creates for one parent behind a single in-flight promise to prevent duplicates (willem-bd #3554). - sidecar-trigger/context: force-restore on trigger click so a sidecar deleted elsewhere self-heals instead of opening a dead thread (willem-bd #3555). - threads/hooks: surface sidecar cascade cleanup failures via console.warn for both lookup and per-thread deletes (Copilot). Add unit + e2e coverage for parallel metadata, atomic create, and trigger self-healing.
56 lines
1.3 KiB
TypeScript
56 lines
1.3 KiB
TypeScript
import { expect, rs, test } from "@rstest/core";
|
|
|
|
import { findSidecarThreadIdsForParent } from "@/core/threads/hooks";
|
|
import type { AgentThread } from "@/core/threads/types";
|
|
|
|
function makeThread(
|
|
threadId: string,
|
|
metadata: Record<string, unknown> = {},
|
|
): AgentThread {
|
|
return {
|
|
thread_id: threadId,
|
|
created_at: "2025-01-01T00:00:00Z",
|
|
updated_at: "2025-01-01T00:00:00Z",
|
|
metadata,
|
|
status: "idle",
|
|
values: { title: threadId, messages: [] },
|
|
} as unknown as AgentThread;
|
|
}
|
|
|
|
test("finds only sidecar threads attached to the deleted parent thread", async () => {
|
|
const search = rs.fn().mockResolvedValueOnce([
|
|
makeThread("sidecar-1", {
|
|
deerflow_sidecar: true,
|
|
parent_thread_id: "parent-1",
|
|
}),
|
|
makeThread("sidecar-other-parent", {
|
|
deerflow_sidecar: true,
|
|
parent_thread_id: "parent-2",
|
|
}),
|
|
makeThread("primary-1"),
|
|
]);
|
|
|
|
await expect(
|
|
findSidecarThreadIdsForParent(
|
|
{
|
|
threads: {
|
|
search,
|
|
},
|
|
},
|
|
"parent-1",
|
|
),
|
|
).resolves.toEqual(["sidecar-1"]);
|
|
|
|
expect(search).toHaveBeenCalledWith({
|
|
metadata: {
|
|
deerflow_sidecar: true,
|
|
parent_thread_id: "parent-1",
|
|
},
|
|
limit: 100,
|
|
offset: 0,
|
|
sortBy: "updated_at",
|
|
sortOrder: "desc",
|
|
select: ["thread_id", "metadata"],
|
|
});
|
|
});
|