mirror of
https://github.com/bytedance/deer-flow.git
synced 2026-07-28 00:48:07 +00:00
* feat(frontend): add side conversations for quoted follow-ups * style(frontend): apply prettier formatting to sidecar-chat files * fix(frontend): surface sidecar cascade cleanup failures via console.warn Previously deleteSidecarThreadsForParent silently swallowed both lookup errors and per-thread deletion failures, so parent thread deletions could succeed while orphaning sidecar threads with no signal to the caller. Log a warning that includes the parent id and the failed thread ids/reasons so the leak is discoverable in telemetry, matching the existing console.warn/error pattern in this file. * fix(frontend): address all sidecar review feedback Resolve every reviewer comment on PR #3934: - input-box/hooks/sidecar-panel: clear quoted references only via an `onSent` callback that fires after the in-flight guard, so a dropped send no longer silently discards quotes (willem-bd #3550). - message-list: flip the selection toolbar below the selection when it would clip above the viewport (willem-bd #3551). - reference-metadata/thread/input-box: keep referenced ids, roles, and count arrays 1:1 parallel instead of deduping ids (willem-bd #3552). - message-list: widen selection containment to the shared assistant-turn container and hint when a selection crosses messages (willem-bd #3553). - sidecar/api: coalesce concurrent sidecar creates for one parent behind a single in-flight promise to prevent duplicates (willem-bd #3554). - sidecar-trigger/context: force-restore on trigger click so a sidecar deleted elsewhere self-heals instead of opening a dead thread (willem-bd #3555). - threads/hooks: surface sidecar cascade cleanup failures via console.warn for both lookup and per-thread deletes (Copilot). Add unit + e2e coverage for parallel metadata, atomic create, and trigger self-healing.
176 lines
4.7 KiB
TypeScript
176 lines
4.7 KiB
TypeScript
import { expect, test } from "@rstest/core";
|
|
|
|
import {
|
|
buildMessageSidecarContext,
|
|
buildParentConversationContext,
|
|
buildSidecarContextPrompt,
|
|
} from "@/core/sidecar/context";
|
|
|
|
test("builds message sidecar context with a readable label", () => {
|
|
const context = buildMessageSidecarContext(
|
|
{ type: "ai", id: "msg-1", content: "A focused answer." },
|
|
3,
|
|
);
|
|
|
|
expect(context).toMatchObject({
|
|
type: "referenced_message",
|
|
label: "Assistant message #3",
|
|
messageId: "msg-1",
|
|
role: "assistant",
|
|
content: "A focused answer.",
|
|
});
|
|
});
|
|
|
|
test("builds sidecar context from selected text", () => {
|
|
const context = buildMessageSidecarContext(
|
|
{
|
|
type: "ai",
|
|
id: "msg-1",
|
|
content: "The full answer includes more detail.",
|
|
},
|
|
2,
|
|
{ selectedText: "includes more detail" },
|
|
);
|
|
|
|
expect(context).toMatchObject({
|
|
type: "referenced_message",
|
|
label: "Selected assistant text #2",
|
|
messageId: "msg-1",
|
|
role: "assistant",
|
|
content: "includes more detail",
|
|
});
|
|
});
|
|
|
|
test("renders hidden sidecar context prompt around quoted material", () => {
|
|
const prompt = buildSidecarContextPrompt({
|
|
type: "referenced_message",
|
|
label: "Selected assistant text #2",
|
|
messageId: "msg-1",
|
|
role: "assistant",
|
|
content: "A side conversation panel.",
|
|
});
|
|
|
|
expect(prompt).toContain("You are answering in a side conversation");
|
|
expect(prompt).toContain(
|
|
'<referenced_message index="1" label="Selected assistant text #2">',
|
|
);
|
|
expect(prompt).toContain("Message ID: msg-1");
|
|
expect(prompt).toContain("A side conversation panel.");
|
|
});
|
|
|
|
test("renders hidden sidecar context prompt around multiple quoted materials", () => {
|
|
const prompt = buildSidecarContextPrompt([
|
|
{
|
|
type: "referenced_message",
|
|
label: "Selected assistant text #2",
|
|
messageId: "msg-1",
|
|
role: "assistant",
|
|
content: "First quoted fragment.",
|
|
},
|
|
{
|
|
type: "referenced_message",
|
|
label: "Selected user text #3",
|
|
messageId: "msg-2",
|
|
role: "user",
|
|
content: "Second quoted fragment.",
|
|
},
|
|
] as never);
|
|
|
|
expect(prompt).toContain('referenced_message index="1"');
|
|
expect(prompt).toContain('referenced_message index="2"');
|
|
expect(prompt).toContain("First quoted fragment.");
|
|
expect(prompt).toContain("Second quoted fragment.");
|
|
});
|
|
|
|
test("builds compact parent conversation context from visible messages", () => {
|
|
const parentContext = buildParentConversationContext([
|
|
{
|
|
type: "human",
|
|
id: "parent-human-1",
|
|
content: "Plan the feature.",
|
|
},
|
|
{
|
|
type: "human",
|
|
id: "hidden-context",
|
|
content: "Hidden implementation note.",
|
|
additional_kwargs: { hide_from_ui: true },
|
|
},
|
|
{
|
|
type: "ai",
|
|
id: "parent-ai-1",
|
|
content: "Use a side conversation with cited snippets.",
|
|
},
|
|
] as never);
|
|
|
|
expect(parentContext).toEqual([
|
|
{
|
|
role: "user",
|
|
messageId: "parent-human-1",
|
|
content: "Plan the feature.",
|
|
},
|
|
{
|
|
role: "assistant",
|
|
messageId: "parent-ai-1",
|
|
content: "Use a side conversation with cited snippets.",
|
|
},
|
|
]);
|
|
});
|
|
|
|
test("renders parent conversation as read-only background in sidecar prompt", () => {
|
|
const prompt = buildSidecarContextPrompt(
|
|
[
|
|
{
|
|
type: "referenced_message",
|
|
label: "Selected assistant text #2",
|
|
messageId: "msg-1",
|
|
role: "assistant",
|
|
content: "Quoted fragment.",
|
|
},
|
|
] as never,
|
|
{
|
|
parentConversation: [
|
|
{
|
|
role: "user",
|
|
messageId: "parent-human-1",
|
|
content: "Plan the feature.",
|
|
},
|
|
{
|
|
role: "assistant",
|
|
messageId: "parent-ai-1",
|
|
content: "Use a side conversation.",
|
|
},
|
|
],
|
|
},
|
|
);
|
|
|
|
expect(prompt).toContain("<parent_conversation_context");
|
|
expect(prompt).toContain(
|
|
'<parent_message index="1" role="User" message_id="parent-human-1">',
|
|
);
|
|
expect(prompt).toContain("Plan the feature.");
|
|
expect(prompt).toContain("Use a side conversation.");
|
|
expect(prompt).toContain('referenced_message index="1"');
|
|
});
|
|
|
|
test("renders parent conversation for sidecar follow-ups without new references", () => {
|
|
const prompt = buildSidecarContextPrompt([], {
|
|
parentConversation: [
|
|
{
|
|
role: "assistant",
|
|
messageId: "parent-ai-1",
|
|
content: "Use a side conversation.",
|
|
},
|
|
],
|
|
});
|
|
|
|
expect(prompt).toContain(
|
|
"The user did not attach new referenced messages for this side question.",
|
|
);
|
|
expect(prompt).toContain(
|
|
"Use parent_conversation_context only as continuity background",
|
|
);
|
|
expect(prompt).toContain("<parent_conversation_context");
|
|
expect(prompt).toContain("Use a side conversation.");
|
|
expect(prompt).not.toContain("<referenced_message");
|
|
});
|