mirror of
https://github.com/bytedance/deer-flow.git
synced 2026-07-28 17:06:05 +00:00
* feat(gateway): add GET /api/features for frontend feature gating (#3757) * feat(agents): add useAgentsApiEnabled feature-flag hook (#3757) * feat(agents): gate /workspace/agents segment on agents_api flag (#3757) * feat(sidebar): grey out Agents button with tooltip when agents_api disabled (#3757) * fix(sidebar): show disabled Agents tooltip on hover, harden a11y + e2e (#3757) - Wrap the disabled Agents button in a hoverable tooltip trigger so the 'feature not enabled' hint shows in the expanded sidebar, not only when collapsed (the SidebarMenuButton tooltip prop is hidden unless collapsed). - Add tabIndex={-1} and drop the redundant onClick preventDefault. - Add e2e coverage for the disabled state + a default /api/features mock. * style(sidebar): move cursor-not-allowed to the hoverable span (#3757) * test(agents): anchor e2e agents-API request filter with a path regex (#3757) * fix(agents): don't expose backend config in disabled message; tell user to contact admin (#3757) The disabled panel previously said 'Set agents_api.enabled: true in config.yaml', leaking backend configuration to end users. Replace with a generic 'not enabled on this server, contact your administrator' message (matching the existing nameStepApiDisabledError copy). e2e now asserts the contact-admin message and that no config.yaml/agents_api text is rendered. * make format * fix(agents): keep agents_api flag sticky during /api/features outage (#3757) Failing open re-mounted the agents UI and re-triggered the 403 storm when agents_api was genuinely disabled and /api/features was down. Persist the last definitive answer and fall back to it (sticky) before failing open, only failing open when nothing has ever been observed. Read the cached value after mount so the first client render matches the server (no hydration mismatch on the non-loading-gated sidebar). * fix(sidebar): make disabled Agents entry keyboard/SR accessible (#3757) The disabled-state explanation was hover-only: tabIndex={-1} removed the entry from the tab order and the reason lived only in a pointer-triggered tooltip. Keep it in the tab order and wire aria-describedby to a visually-hidden reason so keyboard and screen-reader users learn why it is disabled. --------- Co-authored-by: Willem Jiang <willem.jiang@gmail.com>
65 lines
2.1 KiB
TypeScript
65 lines
2.1 KiB
TypeScript
import { afterEach, describe, expect, test } from "@rstest/core";
|
|
|
|
import {
|
|
readCachedAgentsApiEnabled,
|
|
resolveAgentsApiEnabled,
|
|
writeCachedAgentsApiEnabled,
|
|
} from "@/core/agents/feature-cache";
|
|
|
|
describe("resolveAgentsApiEnabled", () => {
|
|
test("a live value always wins over the cache", () => {
|
|
expect(resolveAgentsApiEnabled(true, false)).toBe(true);
|
|
expect(resolveAgentsApiEnabled(false, true)).toBe(false);
|
|
});
|
|
|
|
test("falls back to the cached value when live is unknown (sticky)", () => {
|
|
// Disabled stays disabled during an /api/features outage, so the 403
|
|
// storm (#3757) does not come back.
|
|
expect(resolveAgentsApiEnabled(undefined, false)).toBe(false);
|
|
expect(resolveAgentsApiEnabled(undefined, true)).toBe(true);
|
|
});
|
|
|
|
test("fails open only when nothing has ever been observed", () => {
|
|
expect(resolveAgentsApiEnabled(undefined, undefined)).toBe(true);
|
|
});
|
|
});
|
|
|
|
describe("agents_api feature cache persistence", () => {
|
|
const store = new Map<string, string>();
|
|
const fakeWindow = {
|
|
localStorage: {
|
|
getItem: (k: string) => (store.has(k) ? store.get(k)! : null),
|
|
setItem: (k: string, v: string) => {
|
|
store.set(k, v);
|
|
},
|
|
removeItem: (k: string) => {
|
|
store.delete(k);
|
|
},
|
|
},
|
|
};
|
|
|
|
afterEach(() => {
|
|
store.clear();
|
|
delete (globalThis as { window?: unknown }).window;
|
|
});
|
|
|
|
test("round-trips a persisted value", () => {
|
|
(globalThis as { window?: unknown }).window = fakeWindow;
|
|
writeCachedAgentsApiEnabled(false);
|
|
expect(readCachedAgentsApiEnabled()).toBe(false);
|
|
writeCachedAgentsApiEnabled(true);
|
|
expect(readCachedAgentsApiEnabled()).toBe(true);
|
|
});
|
|
|
|
test("returns undefined when nothing is stored", () => {
|
|
(globalThis as { window?: unknown }).window = fakeWindow;
|
|
expect(readCachedAgentsApiEnabled()).toBeUndefined();
|
|
});
|
|
|
|
test("no-ops without a browser environment (SSR)", () => {
|
|
// window is undefined in the node test environment.
|
|
expect(readCachedAgentsApiEnabled()).toBeUndefined();
|
|
expect(() => writeCachedAgentsApiEnabled(true)).not.toThrow();
|
|
});
|
|
});
|