mirror of
https://github.com/bytedance/deer-flow.git
synced 2026-10-26 13:16:24 +00:00
3b8141aa43
* Fail closed on delegated fetch backends to close SSRF gap * fix(community): resolve delegated-fetch credentials from one config snapshot Address review feedback on the fail-closed SSRF guard: - firecrawl/fastcrw client construction no longer re-reads get_app_config(), so the API key and endpoint come from the same revision the endpoint screen validated (prevents cross-revision credential misrouting). - fix the browserless test double to accept the new two-argument _get_browserless_client signature. - document the check-only (DNS rebinding) caveat on validate_delegated_backend_url. - add a CHANGELOG upgrade note for the default self-hosted backend break. * fix(doctor): consolidate delegated fetch backend checks and deployment guidance --------- Co-authored-by: Willem Jiang <willem.jiang@gmail.com>
92 lines
2.9 KiB
Python
92 lines
2.9 KiB
Python
"""Address classification shared by every SSRF-screened web tool."""
|
|
|
|
import ipaddress
|
|
|
|
import pytest
|
|
|
|
from deerflow.community.url_safety import is_blocked_address, validate_delegated_backend_url, validate_public_http_url
|
|
|
|
|
|
@pytest.mark.parametrize(
|
|
"address",
|
|
[
|
|
"100.64.0.0",
|
|
"100.64.1.1", # CGNAT / Tailscale node
|
|
"100.100.100.200", # Alibaba Cloud ECS instance metadata
|
|
"100.127.255.255",
|
|
"::ffff:100.100.100.200", # IPv4-mapped spelling of the same endpoint
|
|
],
|
|
)
|
|
def test_shared_address_space_is_blocked(address):
|
|
assert is_blocked_address(ipaddress.ip_address(address))
|
|
|
|
|
|
@pytest.mark.parametrize(
|
|
"address",
|
|
[
|
|
"127.0.0.1",
|
|
"10.0.0.5",
|
|
"169.254.169.254",
|
|
"0.0.0.0",
|
|
"224.0.0.1",
|
|
"::1",
|
|
"fe80::1",
|
|
"fc00::1",
|
|
"::ffff:127.0.0.1",
|
|
# NAT64 spelling of a metadata address reports is_global, so the
|
|
# reserved/private flags must keep applying alongside it.
|
|
"64:ff9b::a9fe:a9fe",
|
|
],
|
|
)
|
|
def test_previously_blocked_addresses_stay_blocked(address):
|
|
assert is_blocked_address(ipaddress.ip_address(address))
|
|
|
|
|
|
@pytest.mark.parametrize("address", ["8.8.8.8", "93.184.215.14", "100.63.255.255", "100.128.0.0", "2606:4700:4700::1111"])
|
|
def test_public_addresses_stay_reachable(address):
|
|
assert not is_blocked_address(ipaddress.ip_address(address))
|
|
|
|
|
|
def test_validator_refuses_a_hostname_resolving_into_shared_address_space():
|
|
error = validate_public_http_url("http://metadata.example/latest/meta-data/", resolver=lambda _host: [ipaddress.ip_address("100.100.100.200")])
|
|
|
|
assert error == "Error: Refusing to fetch a private, loopback, or metadata address"
|
|
|
|
|
|
@pytest.mark.parametrize(
|
|
"base_url",
|
|
[
|
|
"http://localhost:3032",
|
|
"http://127.0.0.1:3032",
|
|
"http://10.0.0.5:3032",
|
|
"http://169.254.169.254:3032",
|
|
"http://[::1]:3032",
|
|
],
|
|
)
|
|
def test_delegated_backend_fails_closed_on_private_addresses(base_url):
|
|
error = validate_delegated_backend_url(base_url)
|
|
|
|
assert error is not None
|
|
assert "network_isolation_confirmed" in error
|
|
|
|
|
|
def test_delegated_backend_fails_closed_when_unresolvable():
|
|
error = validate_delegated_backend_url("http://browserless:3000", resolver=lambda _host: [])
|
|
|
|
assert error is not None
|
|
assert "network_isolation_confirmed" in error
|
|
|
|
|
|
def test_delegated_backend_allows_public_address():
|
|
error = validate_delegated_backend_url("https://production-sfo.browserless.io", resolver=lambda _host: [ipaddress.ip_address("93.184.216.34")])
|
|
|
|
assert error is None
|
|
|
|
|
|
def test_delegated_backend_allows_private_when_isolation_confirmed():
|
|
assert validate_delegated_backend_url("http://10.0.0.5:3032", network_isolation_confirmed=True) is None
|
|
|
|
|
|
def test_delegated_backend_rejects_non_http_scheme():
|
|
assert validate_delegated_backend_url("ftp://example.com") == "Error: Only http:// and https:// backend URLs are supported"
|