mirror of
https://github.com/bytedance/deer-flow.git
synced 2026-07-27 00:17:53 +00:00
* feat(checkpoint): dual-mode checkpoint storage with LangGraph DeltaChannel
Add a restart-required database.checkpoint_channel_mode ("full" default,
"delta") that stores the messages channel via LangGraph 1.2 DeltaChannel,
cutting checkpoint storage from O(n^2) to O(n) for append-only history.
Existing full checkpoints seed delta state transparently; no data migration.
- config: mode schema + freeze-on-first-use with
CheckpointModeReconfigurationError; mode marker persisted in checkpoint
metadata; unsafe delta->full downgrade rejected fail-closed with
CheckpointModeMismatchError (run-level error, failed state read)
- state: delta message state schema; CheckpointStateAccessor centralizes
materialized reads for all consumers (threads API, branches,
regeneration, compaction, state updates, memory, goal workers)
- runtime: raw writers (run durations, interrupted title, thread goal)
parent their checkpoints to the checkpoint they derive from, preserving
delta ancestry; rollback forks the pre-run lineage through a state
mutation graph with Overwrite restores; InMemorySaver delta-history
override delegates to the base walk (fixes dropped first write after
migration, also present upstream)
- tests: conformance suite over {memory, sqlite, postgres} covering
migration replay, stable message IDs, storage shape and writer
preservation; conftest fixture isolates the frozen mode between tests;
stale config fakes refreshed
- ci: backend unit tests gain a postgres service
* fix(checkpoint): close materialization gaps in goal flow, guard public factory
- Route goal-continuation message reads through CheckpointStateAccessor:
raw channel_values reads see the delta sentinel in delta mode, which
disabled goal continuation (stand_down=no_durable_end_of_turn) after
durable assistant turns. Raw tuples remain for tuple-only metadata
(checkpoint id, pending_writes).
- Reject checkpoint_channel_mode='delta' + checkpointer in
create_deerflow_agent at construction: factory-built persisted graphs
bypass mode-marker injection and the fail-closed gate, reproducing
silent mixed-mode state loss. Delta without persistence stays allowed.
- Import the postgres saver lazily (pytest.importorskip in the fixture)
so the documented default install collects the suite; add a CI job
running pytest --collect-only on uv sync --group dev without extras.
- Fix test_checkpointer fallback test to patch get_app_config at its
use site (provider module), making it deterministic when a local
config.yaml selects a persistent backend.
* fix(gateway): preserve extension-owned channels in state mutations, bump config version
- build_state_mutation_graph / build_checkpoint_state_mutation_accessor
accept an explicit state_schema; branch and POST /state now compile the
mutation graph from the thread's effective schema
(graph_state_schema on the assistant graph). The base-ThreadState
fallback silently discarded channels contributed by custom
AgentMiddleware.state_schema on branch (data loss) and returned a
false-success 200 on POST /state.
- POST /state validates values keys against the mutation graph's
channels and rejects unknown fields with 422 instead of ignoring
them; reducer detection covers extension channels
(BinaryOperatorAggregate or DeltaChannel) so Overwrite replace
semantics work for middleware reducers in both modes.
- Endpoint regression: custom AgentMiddleware.state_schema value
survives branch, updates through POST /state, and an unknown field
receives 422.
- config_version 26 -> 27 for the new database.checkpoint_channel_mode
(example, Helm chart values + README, support-bundle fixture), so
existing installs get the outdated-config warning and
make config-upgrade merges the field; covered by a test driving the
real example file and the real config-upgrade script.
* fix(gateway): resolve assistant schema via one boundary, copy branch reducer values with Overwrite
GET /threads/{id}/state now resolves the thread's assistant_id through a
single reusable boundary (thread metadata -> assistant_id -> effective
graph), so channels contributed by a custom AgentMiddleware.state_schema
are materialized instead of dropped by the default lead schema. POST
/state uses the same boundary instead of resolving the schema ad hoc.
Branch writes wrap every copied reducer channel in Overwrite (derived
from the effective mutation graph: BinaryOperatorAggregate + DeltaChannel),
not just messages, so already-aggregated values are never re-merged.
Regression tests use a real AgentMiddleware.state_schema with a
non-identity reducer in both full and delta modes: GET /state returns the
extension value, POST /state replaces it, branch preserves it
byte-for-byte; the unknown-field 422 is a separate assertion.
* refactor(checkpoint): collapse read-path round-trips and ship dual-mode parity tests
Address review round 4 on PR #4292:
- Push ahistory/history limit through Pregel into checkpointer.alist
(SQL LIMIT) instead of materializing all rows and breaking in Python
- Fold the read-side mode-compat gate onto the returned snapshot's
metadata; only writes keep the pre-write tuple fetch (fail-closed)
- Cache factory-built accessor graphs per (assistant_id, mode) with
factory-identity revalidation; state reads no longer build a lead
agent per request
- get_thread: one snapshot fetch + one raw pending_writes fetch on the
resolved checkpoint (post-checkpoint __error__ writes never surface
in snapshot.tasks; verified empirically)
- DeerFlowClient.get_thread: single checkpointer.list walk collects
pending_writes per checkpoint instead of N get_tuple calls
- InMemorySaver delta-history patch: stand-down when the upstream
override disappears, try/except guard, validated-version warning,
guard tests
- make_lead_agent mode precedence: first freeze is owned by app_config
(client-supplied configurable key ignored); once frozen, injected
key/app_config must match or fail closed
- Rollback: lock in non-message channel restoration via fork
inheritance with a dedicated reducer-channel test
- Add tests/test_threads_checkpoint_mode.py and
tests/test_gateway_checkpoint_mode.py referenced by AGENTS.md and
the PR validation section: lifecycle parity (memory + sqlite),
per-step blob-count storage guard, gateway endpoint parity
Counted-saver tests pin checkpoint round-trips for aget/ahistory so
these regressions cannot silently return.
* fix(checkpoint): precise mode-mismatch HTTP mapping, gate E2E, and accessor resilience
- threads router: map CheckpointModeMismatchError to 409 (with cause and
thread id) and CheckpointModeReconfigurationError to 503 across all state
endpoints instead of swallowing both into a generic 500
- gate coverage: seed a real delta checkpoint into AsyncSqliteSaver and
assert aget/aupdate/ahistory fail closed; assert 409 at the HTTP boundary
through the real route stack
- rollback: compile the restore mutation graph with the thread's effective
state schema per the build_state_mutation_graph contract
- inheritance contract locks: rollback and manual compaction preserve
middleware-contributed channels via checkpoint fork cloning
- services: revalidate the accessor-graph cache against app_config identity
so config.yaml hot-reloads never serve a stale compiled graph
- services: degrade full-mode state reads to raw checkpointer reads when the
agent factory is unavailable (delta gate still applies; delta mode has no
fallback)
- deps: override websockets==16.0 (langgraph-sdk 0.4.2's <16 pin silently
downgraded 16.0 -> 15.0.1; pin is not grounded in any API incompatibility)
and bump the langchain lower bound to what the lockfile actually resolves
* fix(checkpoint): include anchor checkpoint in degraded history walk + cover get_thread
- _RawCheckpointReadAccessor.ahistory: alist(before=...) is exclusive while
pregel's get_state_history treats config.checkpoint_id as the inclusive
start; fetch the anchor explicitly so both read paths paginate identically
- extend the degraded-path gateway test: GET /thread returns raw values, and
POST /history with before starts at the anchor checkpoint
* fix(gateway): preserve degraded checkpoint timestamps
* fix(gateway): harden degraded checkpoint access
* fix(gateway): resolve assistants for checkpoint reads
---------
Co-authored-by: Willem Jiang <willem.jiang@gmail.com>
148 lines
6.7 KiB
Python
148 lines
6.7 KiB
Python
"""Dual-mode (full/delta) end-to-end parity for thread checkpoint flows.
|
|
|
|
Exercises the same thread lifecycle — multi-turn writes, latest-state read,
|
|
bounded history, branch from an earlier checkpoint, and a compaction-style
|
|
wholesale ``Overwrite`` write — against the production thread state schemas
|
|
(``get_thread_state_schema(mode)``) on both ``InMemorySaver`` and
|
|
``AsyncSqliteSaver``. Every assertion compares the materialized state
|
|
produced by the two modes: delta storage must be behaviorally invisible.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from typing import Any
|
|
|
|
import pytest
|
|
from langchain_core.messages import AIMessage, HumanMessage
|
|
from langgraph.checkpoint.memory import InMemorySaver
|
|
from langgraph.checkpoint.sqlite.aio import AsyncSqliteSaver
|
|
from langgraph.graph import StateGraph
|
|
from langgraph.types import Overwrite
|
|
|
|
from deerflow.agents.thread_state import get_thread_state_schema
|
|
from deerflow.runtime.checkpoint_mode import inject_checkpoint_mode
|
|
from deerflow.runtime.checkpoint_state import (
|
|
CheckpointStateAccessor,
|
|
build_state_mutation_graph,
|
|
)
|
|
|
|
pytestmark = pytest.mark.anyio
|
|
|
|
|
|
def _build_reply_graph(mode: str, checkpointer: Any):
|
|
"""One-node graph on the production thread schema for ``mode``."""
|
|
|
|
async def _reply(state: dict[str, Any]) -> dict[str, Any]:
|
|
n = len(state.get("messages") or [])
|
|
return {"messages": [AIMessage(content=f"answer-{n}", id=f"a{n}")]}
|
|
|
|
builder = StateGraph(get_thread_state_schema(mode))
|
|
builder.add_node("reply", _reply)
|
|
builder.set_entry_point("reply")
|
|
builder.set_finish_point("reply")
|
|
return builder.compile(checkpointer=checkpointer)
|
|
|
|
|
|
def _normalize_messages(values: dict[str, Any]) -> list[tuple[str, str, str]]:
|
|
return [(message.type, message.content, message.id) for message in values.get("messages", [])]
|
|
|
|
|
|
async def _run_thread_lifecycle(mode: str, checkpointer: Any) -> dict[str, Any]:
|
|
"""Drive the full thread lifecycle and return normalized observations."""
|
|
graph = _build_reply_graph(mode, checkpointer)
|
|
accessor = CheckpointStateAccessor.bind(graph, checkpointer, mode=mode)
|
|
config: dict[str, Any] = {"configurable": {"thread_id": "thread-parity"}}
|
|
inject_checkpoint_mode(config, mode)
|
|
|
|
# Multi-turn writes.
|
|
for i in range(3):
|
|
await graph.ainvoke({"messages": [HumanMessage(content=f"question-{i}", id=f"h{i}")]}, config)
|
|
|
|
# Latest materialized state.
|
|
latest = await accessor.aget(config)
|
|
latest_messages = _normalize_messages(latest.values)
|
|
|
|
# Bounded history: limit must hold and the walk must be newest-first.
|
|
history = await accessor.ahistory(config, limit=2)
|
|
history_shapes = [_normalize_messages(snapshot.values) for snapshot in history]
|
|
|
|
# Branch from the first checkpoint (regenerate flow): the fork inherits
|
|
# the pre-branch state, then new writes append on top.
|
|
first_checkpoint_id = history[-1].config["configurable"]["checkpoint_id"]
|
|
branch_config: dict[str, Any] = {"configurable": {"thread_id": "thread-parity", "checkpoint_ns": "", "checkpoint_id": first_checkpoint_id}}
|
|
inject_checkpoint_mode(branch_config, mode)
|
|
await accessor.aupdate(branch_config, {"messages": [HumanMessage(content="retry", id="h-retry")]}, as_node="reply")
|
|
branched = await accessor.aget(branch_config)
|
|
branch_messages = _normalize_messages(branched.values)
|
|
|
|
# Compaction-style wholesale write through the mutation graph: replace
|
|
# the message list with an Overwrite, no node scheduling.
|
|
mutation_graph = build_state_mutation_graph("compact", mode, get_thread_state_schema(mode))
|
|
mutation_accessor = CheckpointStateAccessor.bind(mutation_graph, checkpointer, mode=mode)
|
|
compacted_messages = [HumanMessage(content="summary so far", id="h-summary")]
|
|
await mutation_accessor.aupdate(config, {"messages": Overwrite(compacted_messages)})
|
|
compacted = await accessor.aget(config)
|
|
compacted_messages_seen = _normalize_messages(compacted.values)
|
|
|
|
# The thread keeps working on top of the compacted state.
|
|
await graph.ainvoke({"messages": [HumanMessage(content="after-compact", id="h3b")]}, config)
|
|
resumed = await accessor.aget(config)
|
|
resumed_messages = _normalize_messages(resumed.values)
|
|
|
|
return {
|
|
"latest": latest_messages,
|
|
"history": history_shapes,
|
|
"branch": branch_messages,
|
|
"compacted": compacted_messages_seen,
|
|
"resumed": resumed_messages,
|
|
}
|
|
|
|
|
|
async def test_thread_lifecycle_parity_memory_saver() -> None:
|
|
full = await _run_thread_lifecycle("full", InMemorySaver())
|
|
delta = await _run_thread_lifecycle("delta", InMemorySaver())
|
|
assert full == delta
|
|
|
|
|
|
async def test_thread_lifecycle_parity_sqlite_saver(tmp_path) -> None:
|
|
async with AsyncSqliteSaver.from_conn_string(str(tmp_path / "full.sqlite3")) as saver:
|
|
await saver.setup()
|
|
full = await _run_thread_lifecycle("full", saver)
|
|
async with AsyncSqliteSaver.from_conn_string(str(tmp_path / "delta.sqlite3")) as saver:
|
|
await saver.setup()
|
|
delta = await _run_thread_lifecycle("delta", saver)
|
|
assert full == delta
|
|
|
|
|
|
async def test_delta_thread_avoids_per_step_full_message_blobs(tmp_path) -> None:
|
|
"""Storage-level guard: in delta mode the per-step checkpoints must not
|
|
carry a serialized ``messages`` blob (the channel persists as incremental
|
|
writes plus rare snapshots); full mode re-serializes the whole list into
|
|
every checkpoint, which is exactly the O(N^2) growth delta mode removes."""
|
|
|
|
async def _blob_checkpoint_counts(mode: str, db_name: str) -> tuple[int, int]:
|
|
async with AsyncSqliteSaver.from_conn_string(str(tmp_path / db_name)) as saver:
|
|
await saver.setup()
|
|
graph = _build_reply_graph(mode, saver)
|
|
config: dict[str, Any] = {"configurable": {"thread_id": f"thread-{mode}"}}
|
|
inject_checkpoint_mode(config, mode)
|
|
for i in range(4):
|
|
await graph.ainvoke({"messages": [HumanMessage(content=f"q{i}", id=f"h{i}")]}, config)
|
|
|
|
total = 0
|
|
with_messages_blob = 0
|
|
async for checkpoint_tuple in saver.alist(config):
|
|
total += 1
|
|
if "messages" in checkpoint_tuple.checkpoint.get("channel_values", {}):
|
|
with_messages_blob += 1
|
|
return total, with_messages_blob
|
|
|
|
delta_total, delta_blobs = await _blob_checkpoint_counts("delta", "delta.sqlite3")
|
|
full_total, full_blobs = await _blob_checkpoint_counts("full", "full.sqlite3")
|
|
|
|
assert delta_total > 0 and full_total > 0
|
|
# Delta: at most the periodic snapshot carries a blob; full: every
|
|
# message-writing checkpoint does.
|
|
assert delta_blobs <= 1, f"delta checkpoints re-serialized messages: {delta_blobs}/{delta_total}"
|
|
assert full_blobs >= 4, f"full mode should blob messages per step: {full_blobs}/{full_total}"
|