deer-flow/backend/tests/test_scheduler_gateway_stop_recovery.py
Totoro 2dd2e5415c
feat(scheduled-tasks): finish the user-facing side of conversation schedules (RFC #6340, 1/2) (#6378)
* feat(scheduler): lifecycle rules, goal/limit parity and coded errors for scheduled tasks

- Migration 0031: nullable scheduled_tasks.unmet_streak_after_seq (internal
  streak boundary) and stop_condition (the user's stop rule, own column).
- Stop rule is normalized (stop_rule.py) and appended only at launch; the
  stored prompt never contains it. Wording adapts when scheduler.tool_enabled
  is off.
- Willem 1: page-created tasks get goal evaluation, <standing_notes>, the
  previous-run reference and own-schedule stop; request_stop and the
  scheduled capability no longer require an origin conversation.
- Repository: single reactivation choke point raising
  ScheduledTaskLimitsExhausted; streak boundary moves on goal/prompt/stop
  condition/note changes (not on resume); goal-check failures neither count
  nor reset the streak; pause of a finished task returns "finished"; trials
  on a paused task keep the host pause marker.
- New repository reads: automatic_runs_used_for, active_run_status_for,
  list_manageable_from_thread, thread_relation/thread_run on thread tasks,
  task_ids_for_thread, run_number, and run_number/total_tokens/summary on
  run history rows.
- REST: goal/max_runs/end_at/stop_condition on create and PATCH (null
  clears, naive end_at = task timezone), resume recomputes from now with an
  optional renewal body, once_time_passed, task_finished, limits_exhausted,
  scheduler_not_running on create, trigger returns outcome/existing/thread_id,
  task responses add automatic_runs_used and active_run_status.
- Coded errors {code, message, params} for routes, shared validation and the
  chat capability (scheduled_task_errors.py), pinned by
  contracts/scheduled_task_errors_contract.json; goal notes contract v2 with
  check_failure_codes, scheduled_origin_key and host_run_errors (host_notes.py).
- /api/features adds scheduled_tasks {available, running, tool_enabled,
  min_interval_seconds}; ScheduledTaskService.is_running.
- Docs: six README scheduler sections, API.md scheduled tasks section
  (breaking error shape), CONFIGURATION.md, AGENTS notes, CHANGELOGs.
- Tests: migration 0031, stop rule, error contract, run listing, lifecycle
  over HTTP, repository, service and capability cases; updated tests for the
  new error shape, finished-task pause and head revision.

* feat(scheduler): conversation update/resume, run-conversation authority and readable launches

- schedule_task: update and resume actions, stop_condition and clear_fields
  parameters, plain parameter types (value rules come back as coded results),
  rewritten docstrings for schedule_task and stop_scheduled_task.
- Capability: update/resume share the REST validation and error codes;
  interactive turns in a task's run conversation may manage that task;
  scheduled runs keep only own-stop; grants require a running scheduler.
- Results: compact JSON-safe task views with local times, display card/text,
  last run in list, timezone_source/browser_timezone, now_local; no ISO, user,
  lease or origin fields; stop_instructions removed.
- Timezone: explicit > browser (context.client_timezone, validated in
  start_run and never forwarded to the run config) > not needed for intervals
  and offset run_at > timezone_required.
- Trial gate accepts natural direct requests after acknowledgements and
  particles; trial results report thread_id and existing.
- Scheduled launches: stable message id scheduled-<task_run_id>, server-owned
  deerflow_scheduled_origin metadata with the user-language parts, run thread
  title for fresh-thread tasks.
- Worker records goal continuations in the verdict; lead prompt language rule
  covers stored task text and scheduled runs.
- Docs: six READMEs, CONFIGURATION, API, runtime/tools AGENTS, CHANGELOGs.

* feat(frontend): scheduled-task core types, formatting, errors and glossary

- throwGatewayApiError now throws GatewayApiError (status, code, params,
  rawMessage); message stays the string detail or detail.message
- scheduled-task types gain stop_condition, automatic_runs_used,
  active_run_status, origin/notes, run_number/total_tokens/summary, thread
  relation, trigger result, renewal and scheduled origin; isTaskBusy and
  hasActiveRun helpers
- api: fetchScheduledTask, resume with optional renewal body, typed trigger
  result and update payload with null clears
- hooks: polling at 3 s while a run is active (list, thread list, run
  history), useScheduledTask with live gating and final 404, useInView,
  localized error toasts; run history refreshes tasks when a run finishes
- new pure modules: errors.ts (contract code to localized copy), format.ts
  (relative task times, viewer time, display zone), status.ts, actions.ts,
  run-error.ts; describeTaskSchedule in cron.ts; goal-outcome adds unchecked
  goal checks, describeTaskOutcome and parseStopRunId
- features: scheduled_tasks block with defaults when missing
- buildRunContext sends client_timezone
- titleOfThread takes a localized untitled label; breadcrumb names scheduled
  tasks and agents; reference chips use the localized untitled label
- schedule input: shared browserTimeZone, labelled selects, aria-pressed
  type toggles, interval minimum from the hint template
- i18n: all PR1 scheduled-task keys in en-US and zh-CN, glossary fixes,
  recipe instructions moved into i18n
- e2e mocks follow the new task, trigger, resume, thread-task and features
  shapes; expectNoRawIdentifiers helpers for e2e and DOM tests
- tests for errors, format, cron, status, actions, goal outcome, run errors,
  hooks, run context, thread titles and features; scheduled e2e copy updated

* feat(frontend): list-first scheduled tasks page with outcomes and editable goals

- page.tsx is now a thin composition of components/workspace/scheduled-tasks:
  status tabs (All/Active/Paused/Finished) and search over the task list,
  ?task_id= deep link with router.replace on selection, ?thread_id= chip
  with Show all, empty state, scheduler-off notice and unavailable state
- task list rows show the schedule in words and one status line (next run,
  running now, paused by agent, auto-paused, finished by its cap)
- task detail: status badge, actions from availableActions with reasons,
  More actions menu (Duplicate, Copy task ID, Delete), outcome notice,
  Runs / Stops when / Each run's goal / Does / Notes from chat / History,
  origin chat link; success toasts for every action
- run rows: run number or Trial run, summary, goal and assumption badges,
  continuations, tokens, Open chat link; raw errors and the evaluator
  reason only behind Details
- create/edit/duplicate dialog with goal, stop condition, safety caps and
  advanced agent/context options; PATCH sends only changed fields, null
  clears a cap
- renew dialog raises or removes caps and resumes in one request; a
  limits_exhausted Resume opens it
- removed i18n keys the old page used; added feedback.resumedNoTime
- recorded en-3 and zh-1 page fixtures; scheduled e2e specs rewritten for
  the new page; DOM tests for the detail and the form dialog
- CHANGELOG entries and the frontend AGENTS.md scheduled-task note

* feat(frontend): live schedule card, run conversation provenance and header entry

- schedule_task results (create, update, pause, resume, trial, delete) become
  an assistant:scheduled-task message group rendered as a live card: schedule,
  next run, stop condition with the safety cap, goal, where results go, Run
  once now, Pause/Resume and Open task; the card polls the task only while it
  is on screen and shows deleted, scheduler-off and limits-exhausted states
- one card per task per assistant turn; the card group is not a turn boundary
  for usage, branching, editing, outline or skill attribution
- a human message with deerflow_scheduled_origin stays a human group with
  scheduledOrigin and renders as a "Scheduled run / Trial run" block with the
  task instructions, stop condition and notes collapsed; the launched text is
  never shown and the message is not editable
- readable step labels for schedule_task actions and stop_scheduled_task
- ThreadScheduledTasksButton replaces the header link: hidden without tasks,
  shows the count, links to the task (or the chat filter), and a run's chat
  links to its task
- recorded en-3 / zh-1 chat and run-thread fixtures; chat-card and run-thread
  e2e specs; unit and DOM tests for parsing, grouping, turn boundaries, card,
  run block, header button, step labels and reconnect hydration
- i18n: header.countLabelOne added, unused card.next removed; CHANGELOG and
  frontend AGENTS.md notes

* fix(scheduler): address verification findings

Move the scheduled-task lifecycle guidance from backend/AGENTS.md into the persistence guide and leave a one-line pointer, so the effective AGENTS.md chains for agents/middlewares, sandbox and subagents stay under the 98304-byte hard limit enforced by scripts/check_agent_guidance.py in lint-check.

* fix(scheduler): address review findings

* fix(scheduled-tasks): polish from live acceptance

- zh schedule wording: an interval of one unit reads 每分钟 / 每小时 / 每秒,
  and a saved interval of whole days reads 每天 / 每 2 天 (Every day / Every 2
  days) instead of 每 1 分钟 or 每 24 小时; several units keep the number
- zh spacing: 已于{time} 满足 and 在{time} 的运行中 now leave a space between
  the interpolated time and the Chinese after it; a copy test guards every
  scheduled-task zh string against a placeholder glued to Chinese
- run summary: when the first line of the final reply only leads in to a list
  (ends with ":" or ":"), the list items follow it as plain text (bullets,
  numbering, checkboxes, bold, code and links stripped), joined with ";" for
  CJK text and "; " otherwise, within the 160-character cap
- a schedule_task result (create, update, pause, resume, trial, delete) that
  arrives in a chat invalidates that chat's task list, the tasks list and the
  named task, so the header button and cards update without waiting for the
  idle poll; results already in the loaded history do not refetch
- e2e and unit fixtures are now the live acceptance recordings (DeepSeek
  Flash, demo data, fictional names): live-weekday.json (create, trial, edit,
  pause, resume in one zh chat) and live-minute.json (per-minute chat, run 1
  and run 2, paused by the agent), fetched with GET from the demo Gateway and
  trimmed; the hand-shaped en-3 / zh-1 fixtures are removed and the chat-card,
  run-thread and tasks-page specs run in both locales over the recorded data

* docs(changelog): reference #6378 for the scheduled-tasks entries

* docs(agents): shorten the scheduled-task pointer to stay under the guidance limit

* test(scheduled-tasks): pin the live takes to their recorded time zone

The live fixtures were recorded in Asia/Shanghai, and an interval task
reads in the viewer's zone, so the 16:48 assertions failed on UTC CI
runners. Pin the browser zone in the two live-take e2e specs and the
zh live-take unit test.

* fix(scheduled-tasks): keep untouched end times and drop a chat filter the new task is not in

- The edit, duplicate and renew dialogs keep a stored end time's instant
  while its field still shows it. A minute-precision wall value cannot
  keep seconds or name the later 01:30 of a DST fall-back, so a
  title-only edit moved the cap an hour earlier, and raising the run
  limit re-sent the end time without its seconds.
- Creating or duplicating a task from a chat's task view drops the chat
  filter when the new task does not belong to that chat, instead of
  showing "This task isn't one of this chat's tasks".

* fix(scheduled-tasks): tie pause notices to the pause they describe

- Paused by agent links and times only the run named in last_error. When
  that run is not loaded, the notice shows no link and the task's own time
  instead of an earlier run that also asked to stop.
- The outcome notice reads the latest history page whichever page is
  shown, so browsing older runs no longer swaps the auto-pause reason and
  "Open latest run" to an earlier miss. It shares that page's request.

* fix(scheduled-tasks): three lifecycle gaps found while re-checking review classes

- The edit form compares a cron in the form its schedule input emits, so an
  untouched "0 09 * * 0,6" is not re-sent as "0 9 * * 6,0" and a title-only
  edit no longer re-arms or refuses a finished task.
- Chat resume asks for a timezone, as update does, when a naive end_at would
  land in the UTC placeholder of a zone-free task.
- Re-arming a task clears a host pause marker, as resume does, so a later
  manual pause no longer reads as "Paused by agent".

* fix(scheduled-tasks): keep the notice's latest-runs query from refreshing older pages

useLatestScheduledTaskRuns kept React Query's default refetch on mount,
focus and reconnect, so going offline and back while an older history page
was shown fetched the latest page again. Refreshing stays with the history,
which refreshes the latest page only while it is shown.

* test(scheduled-tasks): let the viewer's time carry its own day label

Between 16:00 and 24:00 UTC, UTC and Asia/Shanghai are on different days,
so the run prompt shows "Tomorrow 01:00 · Today 09:00 your time" and the
fixed "01:00 · 09:00 your time" assertion failed depending on the hour.

---------

Co-authored-by: Totoro-qaq <279883115+Totoro-qaq@users.noreply.github.com>
Co-authored-by: Willem Jiang <willem.jiang@gmail.com>
2026-10-07 07:47:32 +08:00

201 lines
10 KiB
Python

"""Scripted graph, real Gateway/worker/SQL acceptance for self-stop crash recovery.
No model, channel, or external provider is called. A SQLite backup taken after
the real stop tool commits represents the disk state left by a hard crash;
the original worker is then released and cleaned up normally.
"""
import asyncio
import json
import sqlite3
import threading
from datetime import UTC, datetime, timedelta
from pathlib import Path
import pytest
from fastapi.testclient import TestClient
from langchain_core.messages import AIMessage, ToolMessage
from langgraph.graph import END, START, StateGraph
from langgraph.prebuilt import ToolNode
from app.gateway import services
from deerflow.agents.thread_state import get_thread_state_schema
from deerflow.config.app_config import AppConfig, reset_app_config, set_app_config
from deerflow.config.extensions_config import ExtensionsConfig
from deerflow.persistence.scheduled_tasks.model import TERMINAL_RUN_STATUSES
from deerflow.runtime.user_context import DEFAULT_USER_ID
from deerflow.tools.scheduled_tasks import stop_scheduled_task
def _sqlite_backup(source: Path, destination: Path) -> None:
destination.parent.mkdir(parents=True, exist_ok=True)
with sqlite3.connect(source) as original, sqlite3.connect(destination) as snapshot:
original.backup(snapshot)
def _config(database_dir: Path, skills_dir: Path) -> AppConfig:
return AppConfig.model_validate(
{
"sandbox": {"use": "deerflow.sandbox.local:LocalSandboxProvider"},
"database": {"backend": "sqlite", "sqlite_dir": str(database_dir)},
"scheduler": {"enabled": True, "tool_enabled": True, "poll_interval_seconds": 300},
"memory": {"enabled": False, "token_counting": "char"},
"run_events": {"backend": "db"},
"skills": {"path": str(skills_dir)},
}
)
@pytest.mark.no_auto_user
def test_fresh_gateway_boot_recovers_self_stop_once_after_running_snapshot(tmp_path, monkeypatch):
monkeypatch.setenv("DEER_FLOW_AUTH_DISABLED", "1")
monkeypatch.setenv("DEER_FLOW_HOME", str(tmp_path / "home"))
monkeypatch.delenv("DEER_FLOW_ENV", raising=False)
monkeypatch.delenv("ENVIRONMENT", raising=False)
monkeypatch.setattr(ExtensionsConfig, "from_file", lambda *args, **kwargs: ExtensionsConfig())
live_dir, recovery_dir = tmp_path / "live", tmp_path / "recovered"
set_app_config(_config(live_dir, tmp_path / "skills"))
# Import after the isolated configuration is installed. Both apps below use
# create_app's actual middleware and lifespan, including startup recovery.
from app.gateway.app import create_app
apps = []
stop_written = threading.Event()
release = {}
executions = []
def graph_factory(config):
async def request_stop(state):
executions.append(config["configurable"]["thread_id"])
return {"messages": [AIMessage(content="", tool_calls=[{"id": "own-stop", "name": "stop_scheduled_task", "args": {}, "type": "tool_call"}])]}
async def wait_after_stop(state):
receipt = next(message for message in reversed(state["messages"]) if isinstance(message, ToolMessage))
result = json.loads(receipt.content)
assert result.get("stop_requested") is True, result
release["event"] = asyncio.Event()
stop_written.set()
await release["event"].wait()
return {"messages": [AIMessage(content="Requested my schedule to stop.")], "title": "Stop recovery fixture"}
graph = StateGraph(get_thread_state_schema("full"))
graph.add_node("request_stop", request_stop)
graph.add_node("tools", ToolNode([stop_scheduled_task]))
graph.add_node("wait_after_stop", wait_after_stop)
graph.add_edge(START, "request_stop")
graph.add_edge("request_stop", "tools")
graph.add_edge("tools", "wait_after_stop")
graph.add_edge("wait_after_stop", END)
return graph.compile(checkpointer=apps[-1].state.checkpointer)
monkeypatch.setattr(services, "resolve_agent_factory", lambda _assistant_id=None: graph_factory)
task_id = "task-stop-crash"
due = datetime.now(UTC) + timedelta(hours=1)
old_record = None
evidence = {}
try:
app = create_app()
apps.append(app)
with TestClient(app) as client:
origin_response = client.post("/api/threads", json={})
assert origin_response.status_code == 200, origin_response.text
origin = origin_response.json()["thread_id"]
async def admit_and_dispatch():
await app.state.scheduled_task_repo.create(
task_id=task_id,
user_id=DEFAULT_USER_ID,
thread_id=None,
origin_thread_id=origin,
context_mode="fresh_thread_per_run",
assistant_id=None,
title="Stop recovery fixture",
prompt="The work is done; stop this schedule.",
schedule_type="interval",
schedule_spec={"every_seconds": 3600},
timezone="UTC",
next_run_at=due,
)
await app.state.scheduled_task_service.run_once(now=due)
client.portal.call(admit_and_dispatch)
try:
assert stop_written.wait(timeout=10), "The real stop tool did not reach the durable receipt barrier"
async def capture_running_snapshot():
parent = await app.state.scheduled_task_repo.get(task_id, user_id=DEFAULT_USER_ID)
history = await app.state.scheduled_task_run_repo.list_by_task(task_id)
assert len(history) == 1
occurrence = history[0]
durable = await app.state.run_store.get(occurrence["run_id"], user_id=DEFAULT_USER_ID)
assert durable["status"] == "running"
assert occurrence["status"] == "running"
assert occurrence["stop_requested_run_id"] == occurrence["run_id"]
assert parent["status"] == "enabled"
await asyncio.to_thread(_sqlite_backup, live_dir / "deerflow.db", recovery_dir / "deerflow.db")
record = await app.state.run_manager.get(occurrence["run_id"], user_id=DEFAULT_USER_ID)
return record, occurrence
old_record, old_occurrence = client.portal.call(capture_running_snapshot)
evidence["snapshot"] = {"run_status": "running", "occurrence_status": old_occurrence["status"], "stop_requested_run_id": old_occurrence["stop_requested_run_id"]}
finally:
async def release_original_worker():
if "event" in release:
release["event"].set()
if old_record is not None and old_record.task is not None:
await asyncio.wait_for(old_record.task, timeout=10)
client.portal.call(release_original_worker)
assert old_record is not None
assert old_record.status.value == "success"
set_app_config(_config(recovery_dir, tmp_path / "skills"))
recovered_app = create_app()
apps.append(recovered_app)
with TestClient(recovered_app) as client:
paused_response = client.get(f"/api/scheduled-tasks/{task_id}")
assert paused_response.status_code == 200, paused_response.text
paused = paused_response.json()
assert paused["status"] == "paused"
assert paused["last_error"] == f"stopped by the agent in run {old_record.run_id}"
assert paused["run_count"] == 1
async def check_recovered_history_and_late_callback():
history = await recovered_app.state.scheduled_task_run_repo.list_by_task(task_id)
assert len(history) == 1
assert history[0]["status"] in TERMINAL_RUN_STATUSES
await recovered_app.state.scheduled_task_service.run_once(now=due + timedelta(days=1))
assert len(await recovered_app.state.scheduled_task_run_repo.list_by_task(task_id)) == 1
await recovered_app.state.scheduled_task_service.handle_run_completion(old_record)
# The GET response adds derived run state to the stored row.
stored = {key: value for key, value in paused.items() if key not in {"automatic_runs_used", "active_run_status"}}
assert await recovered_app.state.scheduled_task_repo.get(task_id, user_id=DEFAULT_USER_ID) == stored
assert await recovered_app.state.scheduled_task_run_repo.list_by_task(task_id) == history
return history[0]
recovered_occurrence = client.portal.call(check_recovered_history_and_late_callback)
assert len(executions) == 1, "Recovered paused work was dispatched again"
resumed_response = client.post(f"/api/scheduled-tasks/{task_id}/resume")
assert resumed_response.status_code == 200, resumed_response.text
assert resumed_response.json()["status"] == "enabled"
async def replay_old_completion_after_resume():
await recovered_app.state.scheduled_task_service.handle_run_completion(old_record)
current = await recovered_app.state.scheduled_task_repo.get(task_id, user_id=DEFAULT_USER_ID)
assert current["status"] == "enabled"
assert current["run_count"] == 1
return current
restored = client.portal.call(replay_old_completion_after_resume)
evidence["recovery"] = {
"task_status": paused["status"],
"occurrence_status": recovered_occurrence["status"],
"run_count": paused["run_count"],
"dispatch_count": len(executions),
"after_resume_and_old_callback": restored["status"],
}
print("Gateway stop recovery evidence: " + json.dumps(evidence, sort_keys=True))
finally:
reset_app_config()