mirror of
https://github.com/bytedance/deer-flow.git
synced 2026-09-12 15:09:47 +00:00
* fix(scripts): prefer Windows cmd shims for pnpm * fix(scripts): address pnpm Windows review feedback * docs: reduce inherited agent guidance size
174 lines
6.1 KiB
Python
174 lines
6.1 KiB
Python
from __future__ import annotations
|
|
|
|
import json
|
|
import os
|
|
import runpy
|
|
import shutil
|
|
import subprocess
|
|
import sys
|
|
from pathlib import Path
|
|
from types import SimpleNamespace
|
|
|
|
import pytest
|
|
|
|
REPO_ROOT = Path(__file__).resolve().parents[2]
|
|
PNPM_SCRIPT = REPO_ROOT / "scripts" / "pnpm.py"
|
|
FRONTEND_DIR = REPO_ROOT / "frontend"
|
|
PNPM_MODULE = runpy.run_path(str(PNPM_SCRIPT))
|
|
|
|
|
|
def _write_fake_command(bin_dir: Path, name: str, label: str, exit_code: int = 0) -> Path:
|
|
if os.name == "nt":
|
|
path = bin_dir / f"{name}.cmd"
|
|
path.write_text(
|
|
f"@echo off\r\necho {label}^|%CD%^|%*\r\nexit /b {exit_code}\r\n",
|
|
encoding="utf-8",
|
|
)
|
|
else:
|
|
path = bin_dir / name
|
|
path.write_text(
|
|
f"#!/bin/sh\nprintf '%s|%s|%s\\n' '{label}' \"$PWD\" \"$*\"\nexit {exit_code}\n",
|
|
encoding="utf-8",
|
|
)
|
|
path.chmod(0o755)
|
|
return path
|
|
|
|
|
|
def _run_pnpm(
|
|
path: Path,
|
|
*args: str,
|
|
cwd: Path = FRONTEND_DIR,
|
|
) -> subprocess.CompletedProcess[str]:
|
|
env = os.environ.copy()
|
|
env["PATH"] = str(path)
|
|
return subprocess.run(
|
|
[sys.executable, str(PNPM_SCRIPT), *args],
|
|
cwd=cwd,
|
|
env=env,
|
|
capture_output=True,
|
|
text=True,
|
|
check=False,
|
|
shell=False,
|
|
)
|
|
|
|
|
|
def test_runner_prefers_direct_pnpm_and_forwards_arguments(tmp_path: Path):
|
|
bin_dir = tmp_path / "bin"
|
|
bin_dir.mkdir()
|
|
_write_fake_command(bin_dir, "pnpm", "direct")
|
|
_write_fake_command(bin_dir, "corepack", "corepack")
|
|
|
|
result = _run_pnpm(bin_dir, "run", "dev", "--host", "127.0.0.1")
|
|
|
|
assert result.returncode == 0
|
|
assert result.stdout.strip() == f"direct|{FRONTEND_DIR}|run dev --host 127.0.0.1"
|
|
assert "via Corepack" not in result.stderr
|
|
|
|
|
|
def test_runner_prefers_cmd_shim_on_windows(monkeypatch):
|
|
paths = {
|
|
"pnpm": r"C:\tools\pnpm.exe",
|
|
"pnpm.cmd": r"C:\tools\pnpm.cmd",
|
|
}
|
|
find_pnpm_command = PNPM_MODULE["find_pnpm_command"]
|
|
monkeypatch.setitem(find_pnpm_command.__globals__, "os", SimpleNamespace(name="nt"))
|
|
monkeypatch.setitem(find_pnpm_command.__globals__, "shutil", SimpleNamespace(which=paths.get))
|
|
|
|
assert find_pnpm_command() == [paths["pnpm.cmd"]]
|
|
|
|
|
|
def test_runner_prefers_corepack_cmd_shim_on_windows(monkeypatch):
|
|
paths = {
|
|
"corepack": r"C:\tools\corepack.exe",
|
|
"corepack.cmd": r"C:\tools\corepack.cmd",
|
|
}
|
|
find_pnpm_command = PNPM_MODULE["find_pnpm_command"]
|
|
monkeypatch.setitem(find_pnpm_command.__globals__, "os", SimpleNamespace(name="nt"))
|
|
monkeypatch.setitem(find_pnpm_command.__globals__, "shutil", SimpleNamespace(which=paths.get))
|
|
|
|
assert find_pnpm_command() == [paths["corepack.cmd"], "pnpm"]
|
|
|
|
|
|
def test_runner_uses_corepack_pnpm_from_frontend_directory(tmp_path: Path):
|
|
bin_dir = tmp_path / "bin"
|
|
bin_dir.mkdir()
|
|
_write_fake_command(bin_dir, "corepack", "corepack")
|
|
|
|
result = _run_pnpm(bin_dir, "--version")
|
|
|
|
assert result.returncode == 0
|
|
assert result.stdout.strip() == f"corepack|{FRONTEND_DIR}|pnpm --version"
|
|
assert result.stderr.strip() == "Using pnpm via Corepack."
|
|
|
|
package_json = json.loads((FRONTEND_DIR / "package.json").read_text(encoding="utf-8"))
|
|
assert package_json["packageManager"] == "pnpm@10.26.2"
|
|
|
|
|
|
def test_runner_uses_frontend_directory_when_called_from_repo_root(tmp_path: Path):
|
|
bin_dir = tmp_path / "bin"
|
|
bin_dir.mkdir()
|
|
_write_fake_command(bin_dir, "corepack", "corepack")
|
|
|
|
result = _run_pnpm(bin_dir, "--version", cwd=REPO_ROOT)
|
|
|
|
assert result.returncode == 0
|
|
assert result.stdout.strip() == f"corepack|{FRONTEND_DIR}|pnpm --version"
|
|
|
|
|
|
def test_runner_reports_actionable_error_when_pnpm_and_corepack_are_missing(tmp_path: Path):
|
|
bin_dir = tmp_path / "bin"
|
|
bin_dir.mkdir()
|
|
|
|
result = _run_pnpm(bin_dir, "--version")
|
|
|
|
assert result.returncode == 127
|
|
assert "Neither pnpm nor Corepack is available" in result.stderr
|
|
assert "ensure 'corepack' is on PATH" in result.stderr
|
|
|
|
|
|
def test_runner_propagates_selected_pnpm_failure(tmp_path: Path):
|
|
bin_dir = tmp_path / "bin"
|
|
bin_dir.mkdir()
|
|
_write_fake_command(bin_dir, "pnpm", "broken-direct", exit_code=42)
|
|
_write_fake_command(bin_dir, "corepack", "unused-corepack")
|
|
|
|
result = _run_pnpm(bin_dir, "install", "--frozen-lockfile")
|
|
|
|
assert result.returncode == 42
|
|
assert result.stdout.strip() == f"broken-direct|{FRONTEND_DIR}|install --frozen-lockfile"
|
|
assert "pnpm command failed with exit status 42" in result.stderr
|
|
|
|
|
|
def test_official_entrypoints_route_pnpm_through_shared_runner():
|
|
root_makefile = (REPO_ROOT / "Makefile").read_text(encoding="utf-8")
|
|
frontend_makefile = (FRONTEND_DIR / "Makefile").read_text(encoding="utf-8")
|
|
serve_script = (REPO_ROOT / "scripts" / "serve.sh").read_text(encoding="utf-8")
|
|
doctor_script = (REPO_ROOT / "scripts" / "doctor.py").read_text(encoding="utf-8")
|
|
support_bundle_script = (REPO_ROOT / "scripts" / "support_bundle.py").read_text(encoding="utf-8")
|
|
|
|
assert "cd frontend && $(FRONTEND_PNPM) install" in root_makefile
|
|
assert "PNPM = $(PYTHON) ../scripts/pnpm.py" in frontend_makefile
|
|
assert '"$DEERFLOW_PNPM_PYTHON" "$DEERFLOW_PNPM_RUNNER" install --silent' in serve_script
|
|
assert 'DEERFLOW_PNPM_RUNNER="$REPO_ROOT/scripts/pnpm.py"' in serve_script
|
|
assert 'FRONTEND_CMD=\'env PORT=3000 "$DEERFLOW_PNPM_PYTHON" "$DEERFLOW_PNPM_RUNNER" run dev\'' in serve_script
|
|
assert '"\\$DEERFLOW_PNPM_RUNNER\\" run preview"' in serve_script
|
|
assert 'Path(__file__).resolve().with_name("pnpm.py")' in doctor_script
|
|
assert 'project_root / "scripts" / "pnpm.py"' in support_bundle_script
|
|
|
|
|
|
@pytest.mark.skipif(shutil.which("make") is None, reason="GNU make is not on PATH (not bundled with Git Bash on Windows)")
|
|
def test_make_install_dry_run_does_not_invoke_bare_pnpm():
|
|
result = subprocess.run(
|
|
["make", "-n", "install"],
|
|
cwd=REPO_ROOT,
|
|
capture_output=True,
|
|
text=True,
|
|
check=False,
|
|
shell=False,
|
|
)
|
|
|
|
assert result.returncode == 0
|
|
assert "cd frontend && " in result.stdout
|
|
assert "../scripts/pnpm.py install" in result.stdout
|
|
assert "cd frontend && pnpm install" not in result.stdout
|