hataa 47d8ff13b2
feat(authz): account disable/enable across every authentication surface (#4063 gap 3) (#6566)
* feat(authz): account disable/enable across every authentication surface (#4063 gap 3)

Vertical slice 1 of the user-lifecycle work: an operator can suspend an
account and every authentication surface rejects it, while the row —
credentials, role, OAuth linkage — is retained so re-enabling restores
exactly what was suspended.

- users.disabled (NOT NULL, server default 0) via migration
  0036_user_disabled; User/UserResponse carry and expose it.
- Enforcement at all four surfaces: password login (no credential
  comparison happens), JWT session resolution (401 ACCOUNT_DISABLED —
  sessions die at the next request), PAT resolution (the generic 401, no
  oracle), OAuth provisioning (403 with a contact-admin message; the
  link is kept so re-enable restores access).
- SQLiteUserRepository.set_disabled: single-column, serialized write
  (same idiom as update_system_role) with the last-ACTIVE-admin guard —
  disabled admins cannot authenticate, so they cannot restore management
  access; re-enabling is always allowed. Field-scoping completed both
  ways: the credential writer mirrors and never writes disabled, so
  a stale password-change snapshot cannot re-enable a suspended account.
- PATCH /api/v1/admin/users/{id} becomes a partial account update
  (system_role and/or disabled), each field routed to its field-scoped
  writer; empty bodies 422.

Tests 11->18: route (disable/re-enable, last-active-admin 409, empty
422, combined update), real-repo (field isolation both directions,
disabled-admin-not-active, guard inside the serialized write, re-enable
always), login rejection with the CORRECT password (only the disabled
gate can reject) plus resolver-visible flag. Mutations verified red:
guard removed (M19), login gate removed (M20 — after hardening the test
with a real hash so the gate is load-bearing).

* fix(authz): portable boolean default, alternate-authenticator suspension, active-admin role guard

Review round 1 on #6566 — three P1s:

- [PG default] sa.text("0") is a raw integer expression PostgreSQL
  rejects as a BOOLEAN default, breaking startup migration and fresh
  create_all bootstraps alike. Both the migration and the ORM model now
  use sa.false()/false() — dialect-rendered, portable.
- [alternate authenticators] WebSockets bypass AuthMiddleware, so a
  disabled user's still-valid cookie could open a NEW browser/stream
  connection and drive the retained session; the standalone LangGraph
  authenticate callback accepted the same suspended JWT. Both now route
  through a shared post-lookup validator (validate_resolved_session_user
  in deps.py — token_version + disabled in one place) that the HTTP
  dependency also uses, so a lifecycle change lands everywhere at once.
- [active-admin role guard] update_system_role counted every admin row,
  so 'disable B, then demote self' — or a combined {system_role, disabled}
  self-update — could strand the deployment with zero administrators able
  to authenticate or re-enable anyone. The demotion guard now counts
  ACTIVE admins only (disabled admins cannot authenticate), under the same
  serialization boundary.

Tests 18->22: shared-validator verdicts, WS admission after suspension
(real token, real repo), LangGraph-callback admission after suspension,
disable-then-demote-self + combined self-update both rejected (fake-repo
route level and real-repo update_system_role level). Mutations verified
red: helper's disabled check removed (M21 — three admission tests fail),
active-admin predicate reverted to all-admins (M22 — repo-level strand
scenario fails). 366 tests green on the affected surface.

* fix(migrations): chain 0036_user_disabled after upstream 0037

The maintainer main-merge brought 0037_project_document_summaries,
which branched from 0035 independently of this PR's 0036 — alembic now
sees two heads and every engine bootstrap fails. Chain 0036 after 0037
(single head; revision numbers are labels, the graph is what matters).

* fix(migrations): renumber user_disabled to 0038 and follow the chain-test convention

Upstream landed its own 0036 (run_idempotency_request) with 0037 chained
after it while this PR was in review — my 0036_user_disabled collided on
the number and my interim chain-fix (0036 revises 0037) left the graph
in a state upstream's chain tests reject (heads == [0037] hardcoded).

- 0036_user_disabled -> 0038_user_disabled, revises
  0037_project_document_summaries: single head 0038.
- Chain tests follow the repo convention (each migration PR appends the
  new head): 0032/0035 gain the DOC_SUMMARIES link and CURRENT_HEAD =
  0038; 0037's single-head assertion moves to CURRENT_HEAD with its
  own-revision link check unchanged.

* fix(migrations): pin the remaining chain tests to the 0038_user_disabled head

The 0027/0028, 0029 and 0034 chain tests still pinned the single head to
0037_project_document_summaries (and 0034 asserted the head's parent was
0036_run_idempotency_request), so the renumbered lifecycle migration broke
two unit-test shards. Follow the chain-test convention: every pinned head
moves to 0038_user_disabled and 0034 walks the chain through 0037.

* fix(authz): enforce account suspension on the internal-auth dispatch surface

Round-3 review finding: the internal-auth principal is synthesized from
trusted headers without a users-row lookup, so a suspended user with an
active channel binding kept driving the agent, and scheduler-owned runs
(their fabricated in-process requests skip AuthMiddleware entirely) kept
launching. Two gates now enforce the lifecycle there:

- AuthMiddleware rejects owner-bound internal calls whose users row is
  disabled (401 account_disabled) at the single gate every internal HTTP
  call passes through. Auth-disabled mode is exempt (no suspendable
  accounts, and its owner header carries the synthetic identity), and
  owner ids without a users row stay allowed — a nonexistent account
  cannot be suspended.
- start_run re-asserts it at run admission after the owner is resolved
  for attribution: the scheduler records the rejection as the
  occurrence's launch error and no run record is created.

Also addresses the remaining round-3 nits: drop the inline token_version
check duplicated by validate_resolved_session_user, correct the
local_provider comment (login never surfaces ACCOUNT_DISABLED), refresh
the stale 0038 docstring header, and restore the deps module caches in
the two suspension tests instead of leaking a closed engine.

* fix(auth): carry the disabled field on the frontend synthetic users

UserResponse now always includes disabled, so the auth-disabled contract
e2e (gateway /auth/me deep-equals the frontend synthetic user) failed
without the field on AUTH_DISABLED_USER. Add disabled to both synthetic
users and declare it optional on the zod schema — absent still parses as
not disabled for pre-gap-3 backends.

* fix(authz): log when the internal-owner suspension check is skipped

The middleware gate's users-lookup failure path silently degraded to
allow; keep the fail-open behavior but leave a WARNING with the
exception, so a store that cannot be read is observable in production
logs instead of invisible.

---------

Co-authored-by: Willem Jiang <willem.jiang@gmail.com>
2026-10-10 16:43:04 +08:00

247 lines
12 KiB
Python

"""Personal Access Token (PAT) credentials for programmatic API access.
Tokens are ``dfp_`` + base62(32 CSPRNG bytes), shown exactly once in the
create response and persisted only as a SHA-256 digest. Validation is a
digest-indexed lookup plus a constant-time re-comparison, with a single
generic failure surface so a 401 never reveals which check failed.
v1 scopes are exactly the route-permission strings owned by
``app.gateway.authz`` — a PAT can only narrow its owning user's
permissions, never widen them.
"""
from __future__ import annotations
import functools
import hashlib
import hmac
import re
import secrets
from typing import Any
PAT_TOKEN_PREFIX = "dfp_"
PAT_RANDOM_BYTES = 32
# Best-effort ``last_used_at`` writes are throttled per token so high-volume
# automation does not turn every request into a database write.
PAT_LAST_USED_WRITE_INTERVAL_SECONDS = 300.0
PAT_ALLOWED_SCOPES: frozenset[str] = frozenset(
{
"threads:read",
"threads:write",
"threads:delete",
"runs:create",
"runs:read",
"runs:cancel",
"projects:read",
"projects:write",
"projects:delete",
}
)
# Deliberately NOT in PAT_ALLOWED_SCOPES: the route permissions "memory:read",
# "memory:write", "agents:read", and "agents:write" exist in authz
# (they guard the memory/agent routers), but PATs stay on the thread/run
# lifecycle only — _PAT_ROUTE_RULES default-denies the memory/agent routes
# for PAT callers regardless of scopes, so admitting these scopes would not
# even reach those routes. Opening them to PATs is a product decision that
# must change all three of: this set, _PAT_ROUTE_RULES, and the API docs.
PAT_MAX_NAME_LENGTH = 128
# Default-deny route boundary for PAT callers (#5041 review P1-1): scope
# intersection in AuthMiddleware only constrains routes that consult
# ``request.state.auth.permissions`` (``@require_permission``). Authenticated
# mutation routes without that decorator — memory deletion, agent creation,
# credential switching, channel configuration — would otherwise accept a
# PAT holding a single read scope. A route is reachable by PAT only when it
# is explicitly listed here, and only together with the thread/run lifecycle
# the v1 scopes govern; everything else answers 403 regardless of scopes.
_PAT_ROUTE_RULES: tuple[tuple[frozenset[str], re.Pattern[str]], ...] = (
(frozenset({"POST"}), re.compile(r"^/api/threads$")),
(frozenset({"POST"}), re.compile(r"^/api/threads/search$")),
(frozenset({"GET", "PATCH", "DELETE"}), re.compile(r"^/api/threads/[^/]+$")),
(frozenset({"GET", "PUT", "DELETE"}), re.compile(r"^/api/threads/[^/]+/goal$")),
(frozenset({"GET", "POST"}), re.compile(r"^/api/threads/[^/]+/state$")),
(frozenset({"POST"}), re.compile(r"^/api/threads/[^/]+/(compact|history|branches)$")),
(frozenset({"POST"}), re.compile(r"^/api/threads/[^/]+/move$")),
# Projects subtree: same enumerated-no-dead-methods precision as the
# threads/runs rules — only the methods the projects router implements
# are admitted, so a future projects route is default-denied until
# explicitly listed. Scope narrowing (projects:read|write|delete and
# threads:write for move) stays enforced by ``@require_permission``.
(frozenset({"GET", "POST"}), re.compile(r"^/api/projects$")),
# ``/config`` is a literal collection route, not a project id — pinned
# explicitly so its admission never depends on the item regex below.
(frozenset({"GET"}), re.compile(r"^/api/projects/config$")),
(frozenset({"GET", "PATCH", "DELETE"}), re.compile(r"^/api/projects/[^/]+$")),
(frozenset({"POST"}), re.compile(r"^/api/projects/[^/]+/(archive|restore)$")),
(frozenset({"GET"}), re.compile(r"^/api/projects/[^/]+/threads$")),
# Project document shelf (Phase 2 Slice B): enumerated per implemented
# route — list/upload on the collection, content and trash on the item.
(frozenset({"GET", "POST"}), re.compile(r"^/api/projects/[^/]+/documents$")),
(frozenset({"GET"}), re.compile(r"^/api/projects/[^/]+/documents/[^/]+/content$")),
(frozenset({"DELETE"}), re.compile(r"^/api/projects/[^/]+/documents/[^/]+$")),
# Promotion and the conversation-files view (Phase 2 Slice C): save a
# thread file to the shelf, attach a shelf document to a thread, and the
# read-only member-thread file aggregation. Scope narrowing
# (projects:write + threads:read/write as decorated) stays enforced by
# ``@require_permission``.
(frozenset({"POST"}), re.compile(r"^/api/projects/[^/]+/documents/from-thread$")),
(frozenset({"POST"}), re.compile(r"^/api/projects/[^/]+/documents/[^/]+/attach-to-thread/[^/]+$")),
(frozenset({"GET"}), re.compile(r"^/api/projects/[^/]+/thread-files$")),
# Trash tier (Phase 2 Slice D): trash listing, restore, per-document
# purge, and empty-trash — enumerated per implemented route, same
# no-dead-methods precision; scope narrowing (projects:read|write|delete)
# stays enforced by ``@require_permission``.
(frozenset({"GET"}), re.compile(r"^/api/trash/documents$")),
(frozenset({"POST"}), re.compile(r"^/api/trash/documents/[^/]+/(restore|purge)$")),
(frozenset({"POST"}), re.compile(r"^/api/trash/purge$")),
# Runs subtree: enumerated per implemented subroute instead of a
# ``runs(/.*)?`` wildcard, so a route added under /runs is default-denied
# until explicitly listed — the same no-dead-methods precision the
# threads collection rule enforces. The ``{run_id}`` slot necessarily
# matches any single segment; the POST-only collection endpoints sharing
# that depth (stream, wait, regenerate, edit-regenerate) are excluded
# from the GET run-id rule so no unimplemented method is pre-authorized.
(frozenset({"GET", "POST"}), re.compile(r"^/api/threads/[^/]+/runs$")),
(
frozenset({"POST"}),
re.compile(r"^/api/threads/[^/]+/runs/(stream|wait|regenerate/prepare|edit-regenerate/prepare)$"),
),
(
frozenset({"GET"}),
re.compile(r"^/api/threads/[^/]+/runs/(?!stream$|wait$|regenerate$|edit-regenerate$)[^/]+$"),
),
(frozenset({"POST"}), re.compile(r"^/api/threads/[^/]+/runs/[^/]+/cancel$")),
(
frozenset({"GET"}),
re.compile(r"^/api/threads/[^/]+/runs/[^/]+/(join|messages|events|workspace-changes)$"),
),
(frozenset({"GET", "POST"}), re.compile(r"^/api/threads/[^/]+/runs/[^/]+/artifacts/archive$")),
(frozenset({"GET", "POST"}), re.compile(r"^/api/threads/[^/]+/runs/[^/]+/stream$")),
(frozenset({"POST"}), re.compile(r"^/api/runs/(stream|wait)$")),
(frozenset({"GET"}), re.compile(r"^/api/runs/[^/]+/(messages|feedback)$")),
)
_BASE62_ALPHABET = "0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz"
def is_pat_allowed_route(method: str, path: str) -> bool:
"""Return whether the PAT route policy admits *method* + *path*.
Trailing slashes are normalized away so the mounted route and its
redirect-style twin resolve identically.
"""
normalized = path.rstrip("/") or "/"
return any(method in methods and pattern.match(normalized) for methods, pattern in _PAT_ROUTE_RULES)
@functools.cache
def _base62_width(byte_length: int) -> int:
"""Digits sufficient for any *byte_length*-byte value (exact integer math)."""
width = 1
limit = 1 << (8 * byte_length)
while 62**width < limit:
width += 1
return width
def _base62(data: bytes) -> str:
"""Fixed-width big-endian base62 of *data*, ``0``-padded on the left.
``int.from_bytes`` discards leading zero bytes, so an unpadded encoding
would be variable-length (and empty for all-zero input) — any draw below
62**39 would have produced a shorter-than-expected token. The fixed width
keeps every token body exactly ``_base62_width(len(data))`` characters
and makes the format test deterministic.
"""
value = int.from_bytes(data, "big")
digits: list[str] = []
while value:
value, remainder = divmod(value, 62)
digits.append(_BASE62_ALPHABET[remainder])
body = "".join(reversed(digits))
return body.rjust(_base62_width(len(data)), "0")
def generate_pat_token() -> str:
"""Generate a show-once raw token: ``dfp_`` + base62(CSPRNG bytes)."""
return PAT_TOKEN_PREFIX + _base62(secrets.token_bytes(PAT_RANDOM_BYTES))
def pat_token_digest(token: str) -> str:
"""Return the hex SHA-256 digest persisted for *token*."""
return hashlib.sha256(token.encode("utf-8")).hexdigest()
def digest_matches(stored_digest: str | None, token: str) -> bool:
"""Constant-time comparison of *token* against a stored digest."""
if not isinstance(stored_digest, str) or not stored_digest:
return False
return hmac.compare_digest(stored_digest, pat_token_digest(token))
def extract_bearer_token(authorization: str | None) -> str | None:
"""Return the Bearer credential from an Authorization header value.
``None`` means the request carries no Authorization header at all, so the
caller should fall through to the session-cookie path. Any other unusable
value (non-Bearer scheme, empty credential) returns ``""`` so callers
treat it as an invalid credential rather than an absent one.
"""
if authorization is None:
return None
scheme, _, value = authorization.partition(" ")
if scheme.lower() != "bearer":
return ""
return value.strip()
async def authenticate_pat(app: Any, authorization: str | None) -> tuple[Any, frozenset[str]]:
"""Validate the Bearer credential and resolve its owning user.
Returns ``(user, scopes)``. Every token-verdict failure mode — malformed
token, unknown/revoked/expired token, PAT store not configured, missing
owning user — raises the same generic 401 so responses cannot serve as an
oracle on which check failed. Infrastructure errors (store I/O failures)
propagate and fail closed; they are not part of the token verdict.
"""
from fastapi import HTTPException
token = extract_bearer_token(authorization)
if not token or not token.startswith(PAT_TOKEN_PREFIX):
raise HTTPException(status_code=401, detail="Invalid token")
pat_repo = getattr(app.state, "pat_repo", None)
if pat_repo is None:
raise HTTPException(status_code=401, detail="Invalid token")
record = await pat_repo.get_active_by_digest(pat_token_digest(token))
if record is None or not digest_matches(record.get("token_digest"), token):
raise HTTPException(status_code=401, detail="Invalid token")
from app.gateway.deps import get_local_provider
user = await get_local_provider().get_user(str(record["user_id"]))
if user is None:
# The owning user was deleted or became unresolvable; the token is
# dead even though its row survives (deleting a user revokes their
# PATs, without needing a FK cascade).
raise HTTPException(status_code=401, detail="Invalid token")
if getattr(user, "disabled", False):
# Operator-disabled account (#3462 gap 3): the token stays valid on
# disk but resolves nothing while the account is suspended; the same
# generic 401 keeps the verdict from serving as an oracle.
raise HTTPException(status_code=401, detail="Invalid token")
await pat_repo.touch_last_used(str(record["id"]))
return user, frozenset(record.get("scopes") or ())
def validate_scopes(scopes: list[str]) -> list[str]:
"""Validate a creation-time scope list; returns the deduplicated order."""
unknown = sorted(set(scopes) - PAT_ALLOWED_SCOPES)
if unknown:
raise ValueError(f"Unknown PAT scopes: {', '.join(unknown)}")
deduplicated = sorted(set(scopes))
if not deduplicated:
raise ValueError("A PAT must request at least one scope")
return deduplicated