mirror of
https://github.com/bytedance/deer-flow.git
synced 2026-04-26 03:38:06 +00:00
1df389b9d0
* fix: wrap blocking readability call with asyncio.to_thread in web_fetch The readability extractor internally spawns a Node.js subprocess via readabilipy, which blocks the async event loop and causes a BlockingError when web_fetch is invoked inside LangGraph's async runtime. Wrap the synchronous extract_article call with asyncio.to_thread to offload it to a thread pool, unblocking the event loop. Note: community/infoquest/tools.py has the same latent issue and should be addressed in a follow-up PR. Closes #2152 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * test: verify web_fetch offloads extraction via asyncio.to_thread Add a regression test that monkeypatches asyncio.to_thread to confirm readability extraction is offloaded to a worker thread, preventing future refactors from reintroducing the blocking call. Addresses Copilot review feedback on #2157. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Willem Jiang <willem.jiang@gmail.com>
205 lines
7.7 KiB
Python
205 lines
7.7 KiB
Python
"""Tests for JinaClient async crawl method."""
|
|
|
|
import logging
|
|
from unittest.mock import MagicMock
|
|
|
|
import httpx
|
|
import pytest
|
|
|
|
import deerflow.community.jina_ai.jina_client as jina_client_module
|
|
from deerflow.community.jina_ai.jina_client import JinaClient
|
|
from deerflow.community.jina_ai.tools import web_fetch_tool
|
|
|
|
|
|
@pytest.fixture
|
|
def jina_client():
|
|
return JinaClient()
|
|
|
|
|
|
@pytest.mark.anyio
|
|
async def test_crawl_success(jina_client, monkeypatch):
|
|
"""Test successful crawl returns response text."""
|
|
|
|
async def mock_post(self, url, **kwargs):
|
|
return httpx.Response(200, text="<html><body>Hello</body></html>", request=httpx.Request("POST", url))
|
|
|
|
monkeypatch.setattr(httpx.AsyncClient, "post", mock_post)
|
|
result = await jina_client.crawl("https://example.com")
|
|
assert result == "<html><body>Hello</body></html>"
|
|
|
|
|
|
@pytest.mark.anyio
|
|
async def test_crawl_non_200_status(jina_client, monkeypatch):
|
|
"""Test that non-200 status returns error message."""
|
|
|
|
async def mock_post(self, url, **kwargs):
|
|
return httpx.Response(429, text="Rate limited", request=httpx.Request("POST", url))
|
|
|
|
monkeypatch.setattr(httpx.AsyncClient, "post", mock_post)
|
|
result = await jina_client.crawl("https://example.com")
|
|
assert result.startswith("Error:")
|
|
assert "429" in result
|
|
|
|
|
|
@pytest.mark.anyio
|
|
async def test_crawl_empty_response(jina_client, monkeypatch):
|
|
"""Test that empty response returns error message."""
|
|
|
|
async def mock_post(self, url, **kwargs):
|
|
return httpx.Response(200, text="", request=httpx.Request("POST", url))
|
|
|
|
monkeypatch.setattr(httpx.AsyncClient, "post", mock_post)
|
|
result = await jina_client.crawl("https://example.com")
|
|
assert result.startswith("Error:")
|
|
assert "empty" in result.lower()
|
|
|
|
|
|
@pytest.mark.anyio
|
|
async def test_crawl_whitespace_only_response(jina_client, monkeypatch):
|
|
"""Test that whitespace-only response returns error message."""
|
|
|
|
async def mock_post(self, url, **kwargs):
|
|
return httpx.Response(200, text=" \n ", request=httpx.Request("POST", url))
|
|
|
|
monkeypatch.setattr(httpx.AsyncClient, "post", mock_post)
|
|
result = await jina_client.crawl("https://example.com")
|
|
assert result.startswith("Error:")
|
|
assert "empty" in result.lower()
|
|
|
|
|
|
@pytest.mark.anyio
|
|
async def test_crawl_network_error(jina_client, monkeypatch):
|
|
"""Test that network errors are handled gracefully."""
|
|
|
|
async def mock_post(self, url, **kwargs):
|
|
raise httpx.ConnectError("Connection refused")
|
|
|
|
monkeypatch.setattr(httpx.AsyncClient, "post", mock_post)
|
|
result = await jina_client.crawl("https://example.com")
|
|
assert result.startswith("Error:")
|
|
assert "failed" in result.lower()
|
|
|
|
|
|
@pytest.mark.anyio
|
|
async def test_crawl_passes_headers(jina_client, monkeypatch):
|
|
"""Test that correct headers are sent."""
|
|
captured_headers = {}
|
|
|
|
async def mock_post(self, url, **kwargs):
|
|
captured_headers.update(kwargs.get("headers", {}))
|
|
return httpx.Response(200, text="ok", request=httpx.Request("POST", url))
|
|
|
|
monkeypatch.setattr(httpx.AsyncClient, "post", mock_post)
|
|
await jina_client.crawl("https://example.com", return_format="markdown", timeout=30)
|
|
assert captured_headers["X-Return-Format"] == "markdown"
|
|
assert captured_headers["X-Timeout"] == "30"
|
|
|
|
|
|
@pytest.mark.anyio
|
|
async def test_crawl_includes_api_key_when_set(jina_client, monkeypatch):
|
|
"""Test that Authorization header is set when JINA_API_KEY is available."""
|
|
captured_headers = {}
|
|
|
|
async def mock_post(self, url, **kwargs):
|
|
captured_headers.update(kwargs.get("headers", {}))
|
|
return httpx.Response(200, text="ok", request=httpx.Request("POST", url))
|
|
|
|
monkeypatch.setattr(httpx.AsyncClient, "post", mock_post)
|
|
monkeypatch.setenv("JINA_API_KEY", "test-key-123")
|
|
await jina_client.crawl("https://example.com")
|
|
assert captured_headers["Authorization"] == "Bearer test-key-123"
|
|
|
|
|
|
@pytest.mark.anyio
|
|
async def test_crawl_warns_once_when_api_key_missing(jina_client, monkeypatch, caplog):
|
|
"""Test that the missing API key warning is logged only once."""
|
|
jina_client_module._api_key_warned = False
|
|
|
|
async def mock_post(self, url, **kwargs):
|
|
return httpx.Response(200, text="ok", request=httpx.Request("POST", url))
|
|
|
|
monkeypatch.setattr(httpx.AsyncClient, "post", mock_post)
|
|
monkeypatch.delenv("JINA_API_KEY", raising=False)
|
|
|
|
with caplog.at_level(logging.WARNING, logger="deerflow.community.jina_ai.jina_client"):
|
|
await jina_client.crawl("https://example.com")
|
|
await jina_client.crawl("https://example.com")
|
|
|
|
warning_count = sum(1 for record in caplog.records if "Jina API key is not set" in record.message)
|
|
assert warning_count == 1
|
|
|
|
|
|
@pytest.mark.anyio
|
|
async def test_crawl_no_auth_header_without_api_key(jina_client, monkeypatch):
|
|
"""Test that no Authorization header is set when JINA_API_KEY is not available."""
|
|
jina_client_module._api_key_warned = False
|
|
captured_headers = {}
|
|
|
|
async def mock_post(self, url, **kwargs):
|
|
captured_headers.update(kwargs.get("headers", {}))
|
|
return httpx.Response(200, text="ok", request=httpx.Request("POST", url))
|
|
|
|
monkeypatch.setattr(httpx.AsyncClient, "post", mock_post)
|
|
monkeypatch.delenv("JINA_API_KEY", raising=False)
|
|
await jina_client.crawl("https://example.com")
|
|
assert "Authorization" not in captured_headers
|
|
|
|
|
|
@pytest.mark.anyio
|
|
async def test_web_fetch_tool_returns_error_on_crawl_failure(monkeypatch):
|
|
"""Test that web_fetch_tool short-circuits and returns the error string when crawl fails."""
|
|
|
|
async def mock_crawl(self, url, **kwargs):
|
|
return "Error: Jina API returned status 429: Rate limited"
|
|
|
|
mock_config = MagicMock()
|
|
mock_config.get_tool_config.return_value = None
|
|
monkeypatch.setattr("deerflow.community.jina_ai.tools.get_app_config", lambda: mock_config)
|
|
monkeypatch.setattr(JinaClient, "crawl", mock_crawl)
|
|
result = await web_fetch_tool.ainvoke("https://example.com")
|
|
assert result.startswith("Error:")
|
|
assert "429" in result
|
|
|
|
|
|
@pytest.mark.anyio
|
|
async def test_web_fetch_tool_returns_markdown_on_success(monkeypatch):
|
|
"""Test that web_fetch_tool returns extracted markdown on successful crawl."""
|
|
|
|
async def mock_crawl(self, url, **kwargs):
|
|
return "<html><body><p>Hello world</p></body></html>"
|
|
|
|
mock_config = MagicMock()
|
|
mock_config.get_tool_config.return_value = None
|
|
monkeypatch.setattr("deerflow.community.jina_ai.tools.get_app_config", lambda: mock_config)
|
|
monkeypatch.setattr(JinaClient, "crawl", mock_crawl)
|
|
result = await web_fetch_tool.ainvoke("https://example.com")
|
|
assert "Hello world" in result
|
|
assert not result.startswith("Error:")
|
|
|
|
|
|
@pytest.mark.anyio
|
|
async def test_web_fetch_tool_offloads_extraction_to_thread(monkeypatch):
|
|
"""Test that readability extraction is offloaded via asyncio.to_thread to avoid blocking the event loop."""
|
|
import asyncio
|
|
|
|
async def mock_crawl(self, url, **kwargs):
|
|
return "<html><body><p>threaded</p></body></html>"
|
|
|
|
mock_config = MagicMock()
|
|
mock_config.get_tool_config.return_value = None
|
|
monkeypatch.setattr("deerflow.community.jina_ai.tools.get_app_config", lambda: mock_config)
|
|
monkeypatch.setattr(JinaClient, "crawl", mock_crawl)
|
|
|
|
to_thread_called = False
|
|
original_to_thread = asyncio.to_thread
|
|
|
|
async def tracking_to_thread(func, *args, **kwargs):
|
|
nonlocal to_thread_called
|
|
to_thread_called = True
|
|
return await original_to_thread(func, *args, **kwargs)
|
|
|
|
monkeypatch.setattr("deerflow.community.jina_ai.tools.asyncio.to_thread", tracking_to_thread)
|
|
result = await web_fetch_tool.ainvoke("https://example.com")
|
|
assert to_thread_called, "extract_article must be called via asyncio.to_thread to avoid blocking the event loop"
|
|
assert "threaded" in result
|