2 Commits

Author	SHA1	Message	Date
kuse	8ecff3be95	test(config): make refresh_skew rejection test load-bearing (#6080) ... test_refresh_skew_rejects_negative_and_boolean omitted the required token_url, so McpOAuthConfig(refresh_skew_seconds=-1) failed validation on the missing field alone -- deleting the ge=0 bound and the boolean validator would leave the test green. Pass token_url (the same URL the refresh_skew_seconds=0 boundary test uses) so only the guards can satisfy pytest.raises; verified by stripping both guards from extensions_config.py, which now fails exactly the two parametrized cases, and restoring them, which returns the suite to 42 passed. Also move SandboxOwnershipConfig up beside the other config imports and drop the redundant in-test `import pytest` (review nits on #6026). Generated-by: ZCode (GLM, coding agent) Co-authored-by: liwenjie200543 <liwenjie200543@users.noreply.github.com>	2026-09-30 17:21:43 +08:00
kuse	f2f9e6f6fe	fix(config): guard numeric config fields that accepted silently-broken values (#6026) ... * fix(config): guard numeric config fields that accepted silently-broken values Ten numeric fields across six config models admitted zero, negatives, or booleans (YAML/JSON true coerces to 1) and only failed at runtime — or kept running with a nonsense value: - CircuitBreakerConfig: failure_threshold >= 1, recovery_timeout_sec > 0 - McpServerConfig: tool_call_timeout > 0, session_init_timeout > 0 - McpOAuthConfig.refresh_skew_seconds >= 0 (0 stays valid) - ModelConfig.stream_chunk_timeout > 0; context_window keeps gt=0 and gains boolean rejection (review follow-up) - RunEventsConfig.max_trace_content >= 1 - SandboxConfig.port 1..65535, idle_timeout >= 0 (0 = documented disable) - SummarizationConfig.trim_tokens_to_summarize >= 1 Review follow-ups: boolean rejection extended to every bounded numeric sibling in sandbox_config (replicas, acquire_timeout, burst_limit, health_check_skip_seconds, bash_output_max_chars, read_file_output_max_chars, ls_output_max_chars, bash_command_timeout, temporary_grant_ttl, renewal_interval_seconds, ttl_multiplier) so the file is uniform, and to model_config.context_window. Tests cover allow_inf_nan=False rejection (float('inf')/'nan') and the refresh_skew_seconds=0 boundary. Generated-by: ZCode (GLM, coding agent) Authored-by: liwenjie200543 <liwenjie200543@users.noreply.github.com> * style(config): apply Ruff formatting to numeric guards Signed-off-by: Willem Jiang <willem.jiang@gmail.com> --------- Signed-off-by: Willem Jiang <willem.jiang@gmail.com> Co-authored-by: liwenjie200543 <liwenjie200543@users.noreply.github.com> Co-authored-by: Willem Jiang <willem.jiang@gmail.com>	2026-09-30 10:48:26 +08:00