github/deer-flow
1
0
Fork 0
mirror of https://github.com/bytedance/deer-flow.git synced 2026-10-26 13:16:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(tests): write file_signature fixtures as bytes so CRLF never leaks in (#6042)

Browse Source 
On Windows, Path.write_text and the text-mode append translate the
fixtures' newlines to CRLF on disk, so read_config_with_signature
correctly returns b'...info\r\n' while the tests assert the byte-exact
b'...info\n' - three tests fail on Windows (CI's Linux never sees the
translation). The product behavior is correct; the fixtures must write
the exact bytes they assert.

write_bytes / binary append for the three byte-sensitive tests: the
file now passes 10/10 on Windows.
This commit is contained in:
xiaodu55 2026-09-29 21:01:18 +08:00 committed by GitHub
parent 5312271f2b
commit b30be67e00
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
backend/tests/test_file_signature.py
View File

@ -81,7 +81,7 @@ def test_app_config_and_mcp_cache_share_the_same_implementation():
def test_read_config_with_signature_describes_exactly_the_bytes_it_returns(tmp_path: Path):
"""The returned signature must be derived from the returned bytes, not re-read from disk."""
cfg = tmp_path / "config.yaml"
cfg.write_text("log_level: info\n", encoding="utf-8")
cfg.write_bytes(b"log_level: info\n")
data, signature = read_config_with_signature(cfg)
@ -110,7 +110,7 @@ def test_app_config_cache_loader_reads_through_the_shared_reader():
def test_read_config_with_signature_signs_the_bytes_even_when_stat_is_stale(tmp_path: Path, monkeypatch):
"""Size and digest come from the bytes actually read, not from the stat taken before the read."""
cfg = tmp_path / "config.yaml"
cfg.write_text("log_level: info\n", encoding="utf-8")
cfg.write_bytes(b"log_level: info\n")
original_stat = Path.stat
fired = False
@ -119,8 +119,8 @@ def test_read_config_with_signature_signs_the_bytes_even_when_stat_is_stale(tmp_
result = original_stat(self, *args, **kwargs)
if self == cfg and not fired: # the file grows between the stat and the read
fired = True
with cfg.open("a", encoding="utf-8") as handle:
handle.write("# appended after stat\n")
with cfg.open("ab") as handle:
handle.write(b"# appended after stat\n")
return result
monkeypatch.setattr(Path, "stat", stat_then_grow)
@ -135,7 +135,7 @@ def test_read_config_with_signature_signs_the_bytes_even_when_stat_is_stale(tmp_
def test_read_config_with_signature_hashes_the_bytes_it_returns_not_a_second_read(tmp_path: Path, monkeypatch):
"""The digest must be computed from the returned bytes; a second read could see a newer revision."""
cfg = tmp_path / "config.yaml"
cfg.write_text("log_level: info\n", encoding="utf-8")
cfg.write_bytes(b"log_level: info\n")
original_read_bytes = Path.read_bytes
fired = False
@ -144,7 +144,7 @@ def test_read_config_with_signature_hashes_the_bytes_it_returns_not_a_second_rea
data = original_read_bytes(self)
if self == cfg and not fired: # the file is rewritten right after the first read
fired = True
cfg.write_text("log_level: debug\n", encoding="utf-8")
cfg.write_bytes(b"log_level: debug\n")
return data
monkeypatch.setattr(Path, "read_bytes", read_then_rewrite)