github/deer-flow
1
0
Fork 0
mirror of https://github.com/bytedance/deer-flow.git synced 2026-10-26 21:26:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(benchmark): reject negative idle timeouts before provider creation (#7363)

Browse Source 
* fix(benchmark): reject negative idle timeout before provisioning

* test(benchmark): cover registered providers for idle timeout validation
This commit is contained in:
ShiYuan Xiong 2026-10-23 23:56:44 +08:00 committed by GitHub
parent cfe2bec371
commit 75df1be6b7
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 18 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
backend/scripts/benchmark/sandbox/README.md
View File

@ -75,8 +75,10 @@ Python and POSIX utilities required by the selected workload and output sync.
The normal warm-up creates and destroys a separate remote before measurement.
CLI `--replicas` and `--idle-timeout` override their YAML values, including their
CLI defaults (3 and 600). `--image` overrides YAML only when supplied. Connection
settings, including HTTPS and `use_server_proxy`, are retained. The exported
CLI defaults (3 and 600). All providers reject negative `--idle-timeout` values
before provider creation. Zero disables idle reaping, except that the
`idle_timeout` scenario requires a positive value. `--image` overrides YAML only
when supplied. Connection settings, including HTTPS and `use_server_proxy`, are retained. The exported
configuration dimensions contain only image, replicas and idle timeout; credentials,
endpoint and environment are not copied into result rows. Record non-secret SDK,
server and deployment versions separately for reproducibility.

2
backend/scripts/benchmark/sandbox/bench_provider.py
View File

@ -755,6 +755,8 @@ def main(argv: list[str] | None = None) -> int:
raise SystemExit("opensandbox benchmarks do not support --fault-inject or nonzero --health-check-skip-seconds")
if min(args.concurrency, args.users, args.replicas) < 1 or min(args.iterations, args.warmup_iterations) < 0:
raise SystemExit("concurrency, users and replicas must be positive; iteration counts must be nonnegative")
if args.idle_timeout < 0:
raise SystemExit("idle timeout must be nonnegative")
if args.fault_inject is not None and (args.concurrency != 1 or args.no_warmpool or args.scenario != "warm_same_thread"):
raise SystemExit("fault injection requires warm_same_thread, concurrency=1 and an enabled warm pool")
if args.fault_inject is not None and not 0 <= args.fault_inject < args.iterations:

12
backend/tests/test_bench_opensandbox.py
View File

@ -288,3 +288,15 @@ def test_unsupported_options_fail_before_creating_resources(transport, extra):
with pytest.raises(SystemExit, match="opensandbox"):
bench.main(["--provider", "opensandbox", *extra])
assert not transport.remotes
@pytest.mark.parametrize("provider", ["opensandbox", "boxlite", "aio-docker"])
def test_negative_idle_timeout_fails_before_provider_creation(monkeypatch, provider):
assert provider in bench.PROVIDER_FACTORIES
def unexpected_provider(*args, **kwargs):
pytest.fail("invalid idle timeout must be rejected before provisioning")
monkeypatch.setitem(bench.PROVIDER_FACTORIES, provider, unexpected_provider)
with pytest.raises(SystemExit, match="idle timeout must be nonnegative"):
bench.main(["--provider", provider, "--scenario", "warm_same_thread", "--idle-timeout", "-5"])