From 6476eabdf5abd90a209a437f315811ffd7f1a41a Mon Sep 17 00:00:00 2001
From: rayhpeng <rayhpeng@gmail.com>
Date: Fri, 10 Apr 2026 18:54:06 +0800
Subject: [PATCH] fix(feedback): use real threadId and refresh after stream

- Pass threadId prop to MessageListItem instead of reading "new" from URL params
- Invalidate thread-feedback query on stream finish so buttons appear immediately
- Show feedback buttons always visible, copy button on hover only

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
---
 .../workspace/messages/message-list-item.tsx     | 16 ++++++++++++++--
 .../workspace/messages/message-list.tsx          |  1 +
 frontend/src/core/threads/hooks.ts               |  1 +
 3 files changed, 16 insertions(+), 2 deletions(-)

diff --git a/frontend/src/components/workspace/messages/message-list-item.tsx b/frontend/src/components/workspace/messages/message-list-item.tsx
index a5faf4cd1..9f22f5160 100644
--- a/frontend/src/components/workspace/messages/message-list-item.tsx
+++ b/frontend/src/components/workspace/messages/message-list-item.tsx
@@ -36,11 +36,13 @@ import { MarkdownContent } from "./markdown-content";
 
 export function MessageListItem({
   className,
+  threadId,
   message,
   isLoading,
   threadId,
 }: {
   className?: string;
+  threadId?: string;
   message: Message;
   isLoading?: boolean;
   threadId: string;
@@ -61,10 +63,13 @@ export function MessageListItem({
         <MessageToolbar
           className={cn(
             isHuman ? "-bottom-9 justify-end" : "-bottom-8",
-            "absolute right-0 left-0 z-20 opacity-0 transition-opacity delay-200 duration-300 group-hover/conversation-message:opacity-100",
+            "absolute right-0 left-0 z-20",
+            !isHuman && runId && threadId
+              ? "opacity-100"
+              : "opacity-0 transition-opacity delay-200 duration-300 group-hover/conversation-message:opacity-100",
           )}
         >
-          <div className="flex gap-1">
+          <div className="flex gap-1 opacity-0 transition-opacity delay-200 duration-300 group-hover/conversation-message:opacity-100">
             <CopyButton
               clipboardData={
                 extractContentFromMessage(message) ??
@@ -73,6 +78,13 @@ export function MessageListItem({
               }
             />
           </div>
+          {!isHuman && runId && threadId && (
+            <FeedbackButtons
+              threadId={threadId}
+              runId={runId}
+              initialFeedback={feedback ?? null}
+            />
+          )}
         </MessageToolbar>
       )}
     </AIElementMessage>
diff --git a/frontend/src/components/workspace/messages/message-list.tsx b/frontend/src/components/workspace/messages/message-list.tsx
index 28acad1cf..89a638470 100644
--- a/frontend/src/components/workspace/messages/message-list.tsx
+++ b/frontend/src/components/workspace/messages/message-list.tsx
@@ -77,6 +77,7 @@ export function MessageList({
               return (
                 <MessageListItem
                   key={`${group.id}/${msg.id}`}
+                  threadId={threadId}
                   message={msg}
                   isLoading={thread.isLoading}
                   runId={runId}
diff --git a/frontend/src/core/threads/hooks.ts b/frontend/src/core/threads/hooks.ts
index 333c04fb7..36ac28628 100644
--- a/frontend/src/core/threads/hooks.ts
+++ b/frontend/src/core/threads/hooks.ts
@@ -294,6 +294,7 @@ export function useThreadStream({
     onFinish(state) {
       listeners.current.onFinish?.(state.values);
       void queryClient.invalidateQueries({ queryKey: ["threads", "search"] });
+      void queryClient.invalidateQueries({ queryKey: ["thread-feedback"] });
     },
   });