From 092bf13f5e1b3f9f76c08a332051b4bb76257107 Mon Sep 17 00:00:00 2001 From: Asish Kumar <87874775+officialasishkumar@users.noreply.github.com> Date: Sat, 11 Apr 2026 07:00:22 +0530 Subject: [PATCH] fix(makefile): route Windows shell-script targets through Git Bash (#2060) --- Makefile | 75 +++++++++++++++++--------------------------------------- 1 file changed, 23 insertions(+), 52 deletions(-) diff --git a/Makefile b/Makefile index 57896e88b..5881e9f60 100644 --- a/Makefile +++ b/Makefile @@ -9,8 +9,11 @@ BACKEND_UV_RUN = cd backend && uv run ifeq ($(OS),Windows_NT) SHELL := cmd.exe PYTHON ?= python + # Run repo shell scripts through Git Bash when Make is launched from cmd.exe / PowerShell. + RUN_WITH_GIT_BASH = call scripts\run-with-git-bash.cmd else PYTHON ?= python3 + RUN_WITH_GIT_BASH = endif help: @@ -58,7 +61,7 @@ config: @$(PYTHON) ./scripts/configure.py config-upgrade: - @./scripts/config-upgrade.sh + @$(RUN_WITH_GIT_BASH) ./scripts/config-upgrade.sh # Check required tools check: @@ -116,78 +119,46 @@ setup-sandbox: # Start all services in development mode (with hot-reloading) dev: @$(PYTHON) ./scripts/check.py -ifeq ($(OS),Windows_NT) - @call scripts\run-with-git-bash.cmd ./scripts/serve.sh --dev -else - @./scripts/serve.sh --dev -endif + @$(RUN_WITH_GIT_BASH) ./scripts/serve.sh --dev # Start all services in dev + Gateway mode (experimental: agent runtime embedded in Gateway) dev-pro: @$(PYTHON) ./scripts/check.py -ifeq ($(OS),Windows_NT) - @call scripts\run-with-git-bash.cmd ./scripts/serve.sh --dev --gateway -else - @./scripts/serve.sh --dev --gateway -endif + @$(RUN_WITH_GIT_BASH) ./scripts/serve.sh --dev --gateway # Start all services in production mode (with optimizations) start: @$(PYTHON) ./scripts/check.py -ifeq ($(OS),Windows_NT) - @call scripts\run-with-git-bash.cmd ./scripts/serve.sh --prod -else - @./scripts/serve.sh --prod -endif + @$(RUN_WITH_GIT_BASH) ./scripts/serve.sh --prod # Start all services in prod + Gateway mode (experimental) start-pro: @$(PYTHON) ./scripts/check.py -ifeq ($(OS),Windows_NT) - @call scripts\run-with-git-bash.cmd ./scripts/serve.sh --prod --gateway -else - @./scripts/serve.sh --prod --gateway -endif + @$(RUN_WITH_GIT_BASH) ./scripts/serve.sh --prod --gateway # Start all services in daemon mode (background) dev-daemon: @$(PYTHON) ./scripts/check.py -ifeq ($(OS),Windows_NT) - @call scripts\run-with-git-bash.cmd ./scripts/serve.sh --dev --daemon -else - @./scripts/serve.sh --dev --daemon -endif + @$(RUN_WITH_GIT_BASH) ./scripts/serve.sh --dev --daemon # Start daemon + Gateway mode (experimental) dev-daemon-pro: @$(PYTHON) ./scripts/check.py -ifeq ($(OS),Windows_NT) - @call scripts\run-with-git-bash.cmd ./scripts/serve.sh --dev --gateway --daemon -else - @./scripts/serve.sh --dev --gateway --daemon -endif + @$(RUN_WITH_GIT_BASH) ./scripts/serve.sh --dev --gateway --daemon # Start prod services in daemon mode (background) start-daemon: @$(PYTHON) ./scripts/check.py -ifeq ($(OS),Windows_NT) - @call scripts\run-with-git-bash.cmd ./scripts/serve.sh --prod --daemon -else - @./scripts/serve.sh --prod --daemon -endif + @$(RUN_WITH_GIT_BASH) ./scripts/serve.sh --prod --daemon # Start prod daemon + Gateway mode (experimental) start-daemon-pro: @$(PYTHON) ./scripts/check.py -ifeq ($(OS),Windows_NT) - @call scripts\run-with-git-bash.cmd ./scripts/serve.sh --prod --gateway --daemon -else - @./scripts/serve.sh --prod --gateway --daemon -endif + @$(RUN_WITH_GIT_BASH) ./scripts/serve.sh --prod --gateway --daemon # Stop all services stop: - @./scripts/serve.sh --stop + @$(RUN_WITH_GIT_BASH) ./scripts/serve.sh --stop # Clean up clean: stop @@ -203,29 +174,29 @@ clean: stop # Initialize Docker containers and install dependencies docker-init: - @./scripts/docker.sh init + @$(RUN_WITH_GIT_BASH) ./scripts/docker.sh init # Start Docker development environment docker-start: - @./scripts/docker.sh start + @$(RUN_WITH_GIT_BASH) ./scripts/docker.sh start # Start Docker in Gateway mode (experimental) docker-start-pro: - @./scripts/docker.sh start --gateway + @$(RUN_WITH_GIT_BASH) ./scripts/docker.sh start --gateway # Stop Docker development environment docker-stop: - @./scripts/docker.sh stop + @$(RUN_WITH_GIT_BASH) ./scripts/docker.sh stop # View Docker development logs docker-logs: - @./scripts/docker.sh logs + @$(RUN_WITH_GIT_BASH) ./scripts/docker.sh logs # View Docker development logs docker-logs-frontend: - @./scripts/docker.sh logs --frontend + @$(RUN_WITH_GIT_BASH) ./scripts/docker.sh logs --frontend docker-logs-gateway: - @./scripts/docker.sh logs --gateway + @$(RUN_WITH_GIT_BASH) ./scripts/docker.sh logs --gateway # ========================================== # Production Docker Commands @@ -233,12 +204,12 @@ docker-logs-gateway: # Build and start production services up: - @./scripts/deploy.sh + @$(RUN_WITH_GIT_BASH) ./scripts/deploy.sh # Build and start production services in Gateway mode up-pro: - @./scripts/deploy.sh --gateway + @$(RUN_WITH_GIT_BASH) ./scripts/deploy.sh --gateway # Stop and remove production containers down: - @./scripts/deploy.sh down + @$(RUN_WITH_GIT_BASH) ./scripts/deploy.sh down