From aeb90676a4c9a29bc487e8ccc6bed94292e95f8d Mon Sep 17 00:00:00 2001
From: jiangnan <1394485448@qq.com>
Date: Fri, 6 Mar 2026 06:02:40 +0800
Subject: [PATCH] Address review feedback on Security Engineer agent

- Add Security Engineer to README Engineering Division table
- Update Semgrep action from returntocorp to semgrep namespace
- Update Pydantic example to v2 syntax (field_validator + classmethod)
---
 README.md                                    |  1 +
 engineering/engineering-security-engineer.md | 14 ++++++++------
 2 files changed, 9 insertions(+), 6 deletions(-)

diff --git a/README.md b/README.md
index 03c599e..d212ce5 100644
--- a/README.md
+++ b/README.md
@@ -61,6 +61,7 @@ Building the future, one commit at a time.
 | 🚀 [DevOps Automator](engineering/engineering-devops-automator.md) | CI/CD, infrastructure automation, cloud ops | Pipeline development, deployment automation, monitoring |
 | ⚡ [Rapid Prototyper](engineering/engineering-rapid-prototyper.md) | Fast POC development, MVPs | Quick proof-of-concepts, hackathon projects, fast iteration |
 | 💎 [Senior Developer](engineering/engineering-senior-developer.md) | Laravel/Livewire, advanced patterns | Complex implementations, architecture decisions |
+| 🔒 [Security Engineer](engineering/engineering-security-engineer.md) | Threat modeling, secure code review, security architecture | Application security, vulnerability assessment, security CI/CD |
 
 ### 🎨 Design Division
 
diff --git a/engineering/engineering-security-engineer.md b/engineering/engineering-security-engineer.md
index b690e91..fb283aa 100644
--- a/engineering/engineering-security-engineer.md
+++ b/engineering/engineering-security-engineer.md
@@ -83,7 +83,7 @@ You are **Security Engineer**, an expert application security engineer who speci
 
 from fastapi import FastAPI, Depends, HTTPException, status
 from fastapi.security import HTTPBearer
-from pydantic import BaseModel, Field, validator
+from pydantic import BaseModel, Field, field_validator
 import re
 
 app = FastAPI()
@@ -94,14 +94,16 @@ class UserInput(BaseModel):
     username: str = Field(..., min_length=3, max_length=30)
     email: str = Field(..., max_length=254)
 
-    @validator("username")
-    def validate_username(cls, v):
+    @field_validator("username")
+    @classmethod
+    def validate_username(cls, v: str) -> str:
         if not re.match(r"^[a-zA-Z0-9_-]+$", v):
             raise ValueError("Username contains invalid characters")
         return v
 
-    @validator("email")
-    def validate_email(cls, v):
+    @field_validator("email")
+    @classmethod
+    def validate_email(cls, v: str) -> str:
         if not re.match(r"^[^@\s]+@[^@\s]+\.[^@\s]+$", v):
             raise ValueError("Invalid email format")
         return v
@@ -159,7 +161,7 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       - name: Run Semgrep SAST
-        uses: returntocorp/semgrep-action@v1
+        uses: semgrep/semgrep-action@v1
         with:
           config: >-
             p/owasp-top-ten